tests: only refresh the minimum sysinfo in mem limit tests. #15702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we run the extended tests on this PR? |
|
Run extended tests |
|
it is still running |
|
I don't think it does, the spawning crashed, there's nothing running here: https://github.com/apache/datafusion/actions?query=workflow%3A%22Datafusion+extended+tests%22 |
|
The CI issue is hopefully fixed here: #15704 |
|
Thank you for the fix. To test this PR, I think you can push the change to your cloned repository of |
|
Tests seem to finish nicely: https://github.com/ashdnazg/datafusion/actions/runs/14442804912/job/40496805764 |
|
Thank you @ashdnazg and @jayzhan211 |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently the memory limit tests hang due to lock contention and the overhead from frequently calling
sysinfo::System::refresh_all()in the memory monitoring task.In fact, we don't really need to refresh all info, it's enough to just get the memory data about the current process, which significantly reduces the refresh time and the tests finish quickly.
What changes are included in this PR?
In the memory limit utils, the memory monitoring spawned task now refreshes system info only for what's actually necessary.
Are these changes tested?
It's part of the tests, and they seem to not hang anymore :)
Are there any user-facing changes?
No