Skip to content

tests: only refresh the minimum sysinfo in mem limit tests. #15702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

tests: only refresh the minimum sysinfo in mem limit tests. #15702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions datafusion/core/tests/memory_limit/memory_limit_validation/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use datafusion_common_runtime::SpawnedTask;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
use sysinfo::System;
use sysinfo::{ProcessRefreshKind, ProcessesToUpdate, System};
use tokio::time::{interval, Duration};

use datafusion::prelude::{SessionConfig, SessionContext};
Expand Down Expand Up @@ -62,7 +62,11 @@ where

loop {
interval.tick().await;
sys.refresh_all();
sys.refresh_processes_specifics(
ProcessesToUpdate::Some(&[pid]),
true,
ProcessRefreshKind::nothing().with_memory(),
);
if let Some(process) = sys.process(pid) {
let rss_bytes = process.memory();
max_rss_clone
Expand Down Expand Up @@ -116,8 +120,8 @@ where
/// # Example
///
/// utils::validate_query_with_memory_limits(
/// 40_000_000 * 2,
/// Some(40_000_000),
/// 40_000_000 * 2,
/// Some(40_000_000),
/// "SELECT * FROM generate_series(1, 100000000) AS t(i) ORDER BY i",
/// "SELECT * FROM generate_series(1, 10000000) AS t(i) ORDER BY i"
/// );
Expand Down