feat: support distinct for window #16925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
zhuqi-lucas
changed the title
|
FYI @crepererum |
|
Follow-up, we need to support more sliding distinct Accumulator: Currently, this PR only support sliding distinct Accumulator for count. But it should be easy because we already supported the whole steps from sql to physical plan with distinct in this PR. I can create follow-up PRs after this PR. |
crepererum
approved these changes
Jul 28, 2025
|
Thank you @crepererum for review! |
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 29, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 29, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 29, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
Omega359
reviewed
Jul 29, 2025
| window_frame, | ||
| aggregate, | ||
| ) | ||
| if distinct { |
There was a problem hiding this comment.
let aggregate = if distinct {..} else {..};
window_expr_from_aggregate_expr(
partition_by,
order_by,
window_frame,
aggregate,
)?
There was a problem hiding this comment.
Thank you @Omega359 for good suggestion and review, i will address it in any follow-up PR for me.
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Aug 25, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Sep 5, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 6, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
fsdvh
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Oct 10, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 21, 2025
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
support distinct for window
Details for window:
Follow-up, improve the performance for SlidingDistinctCountAccumulator, because we may can add each type specific for it also.
What changes are included in this PR?
support distinct for window
Details for window:
Follow-up, improve the performance for SlidingDistinctCountAccumulator, because we may can add each type specific for it also.
Are these changes tested?
Yes
Are there any user-facing changes?
New feature support now