feat: Support distinct window for sum #16943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
Contributor
Author
|
We added the new feature for support distinct operation for window, and added count support already. FYI @crepererum @alamb , this is the follow-up for |
zhuqi-lucas
changed the title
zhuqi-lucas
commented
Jul 28, 2025
| ) AS distinct_count | ||
| FROM table_test_distinct_count | ||
| ODER BY k, time; | ||
| ORDER BY k, time; |
Contributor
Author
There was a problem hiding this comment.
Minor, this is fix the typo here.
Contributor
There was a problem hiding this comment.
Context: This came from #16887 and @zhuqi-lucas spotted my mistake in #16888.
zhuqi-lucas
commented
Jul 28, 2025
| 07)------------DataSourceExec: partitions=2, partition_sizes=[5, 4] | ||
|
|
||
|
|
||
| # Add testing for distinct sum |
Contributor
Author
There was a problem hiding this comment.
This is the corresponding slt testing for this PR.
Contributor
Author
|
Same as the count, i will try to improve the performance as follow-ups, but it will after my PRs for the missing features. |
crepererum
approved these changes
Jul 28, 2025
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
* feat: support sum distinct for window * fmt * fmt * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We added the new feature for support distinct operation for window, and added count support.
This PR is to add sum support.
Rationale for this change
We added the new feature for support distinct operation for window, and added count support.
This PR is to add sum support.
Also fix the typo in window.slt.
What changes are included in this PR?
Are these changes tested?
Yes, slt testing added.
Are there any user-facing changes?
New sum distinct feature supported.