Add assertion that ScalarUDFImpl implementation is consistent with declared return type

[findepi]

The planner takes into account the return type a function promises to return. It even passes it back on invoke as a reminder/convenience. Verify that each function delivers on the promise.

• follows bug: Support null as argument to to_local_time #17491 (comment)

[findepi]

This failed locally. I hope the CI will fail too. If not, need to update how the check is conditioned.

[findepi]

External error: 8 errors in file /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/array/array.slt

1. query failed: DataFusion error: Execution error: Function 'array' returned value of type 'List(Field { name: "element", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })' while the following type was promised at planning time and expected: 'List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })'
[SQL] SELECT array(1, 2, 3);
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/array/array.slt:18


2. query failed: DataFusion error: Execution error: Function 'array' returned value of type 'List(Field { name: "element", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })' while the following type was promised at planning time and expected: 'List(Field { name: "item", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })'
[SQL] SELECT array('a', 'b');
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/array/array.slt:24


3. query failed: DataFusion error: Execution error: Function 'array' returned value of type 'List(Field { name: "item", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })' while the following type was promised at planning time and expected: 'List(Field { name: "element", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })'
[SQL] SELECT array();
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/array/array.slt:30


4. query failed: DataFusion error: Execution error: Function 'array' returned value of type 'List(Field { name: "item", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })' while the following type was promised at planning time and expected: 'List(Field { name: "element", data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })'
[SQL] SELECT array(), array(array());
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/array/array.slt:35


5. query failed: DataFusion error: Execution error: Function 'array' returned value of type 'List(Field { name: "element", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })' while the following type was promised at planning time and expected: 'List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })'
[SQL] SELECT array(1, NULL, 3);

7. query failed: DataFusion error: Execution error: Function 'parse_url' returned value of type 'Utf8' while the following type was promised at planning time and expected: 'Utf8View'
[SQL] SELECT parse_url('http://userinfo@spark.apache.org/path?query=1#Ref'::string, 'REF'::string);
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/url/parse_url.slt:48


8. query failed: DataFusion error: Execution error: Function 'parse_url' returned value of type 'Utf8' while the following type was promised at planning time and expected: 'Utf8View'
[SQL] SELECT parse_url('http://userinfo@spark.apache.org/path?query=1#Ref'::string, 'PROTOCOL'::string);
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/url/parse_url.slt:53


9. query failed: DataFusion error: Execution error: Function 'parse_url' returned value of type 'Utf8' while the following type was promised at planning time and expected: 'Utf8View'
[SQL] SELECT parse_url('http://userinfo@spark.apache.org/path?query=1#Ref'::string, 'FILE'::string);
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/url/parse_url.slt:58


10. query failed: DataFusion error: Execution error: Function 'parse_url' returned value of type 'Utf8' while the following type was promised at planning time and expected: 'Utf8View'
[SQL] SELECT parse_url('http://userinfo@spark.apache.org/path?query=1#Ref'::string, 'AUTHORITY'::string);
at /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/url/parse_url.slt:63


... other 1 errors in /Users/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/spark/url/parse_url.slt not shown ...

[alamb]

Thanks @findepi ! Given we found several other bugs with this assertion I think the value is clear 👍

I had some small style suggestions, but nothing I think is needed

[adriangb]

Makes sense to me!