Add debug log when waiting for spilling on other consumers #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Mar 6, 2022
| @@ -340,6 +340,9 @@ impl MemoryManager { | |||
| } else if current < min_per_rqt { | |||
| // if we cannot acquire at lease 1/2n memory, just wait for others | |||
| // to spill instead spill self frequently with limited total mem | |||
| debug!( | |||
| "Cannot acquire minimum amount of memory {}, waiting for others to spill ...", | |||
| human_readable_size(min_per_rqt)); | |||
There was a problem hiding this comment.
I'm also thinking if it makes sense to measure the time spent on the wait and log it?
There was a problem hiding this comment.
How do you like to also log memory manager status as well?
impl Display for MemoryManager {
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
write!(f,
"MemoryManager usage statistics: total {}, trackers used {}, total {} requesters used: {}",There was a problem hiding this comment.
One more thought, based on your measure timing comments above, probably we could warn! if we've waited for a longer time than some threshold? In case reproducing the race would be hard. debug! at the first round might not be revealed in the first place?
There was a problem hiding this comment.
warn! sounds better. Do you think we need to have warn! for all log here? Or just for longer time case?
There was a problem hiding this comment.
For the longer time case, I suggest.
|
cc @yjshen |
yjshen
approved these changes
Mar 8, 2022
houqp
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1932.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?