Add serialization of ScalarValue::IntervalMonthDayNano
#3535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3535 +/- ##
==========================================
- Coverage 85.92% 85.91% -0.01%
==========================================
Files 301 300 -1
Lines 56249 56257 +8
==========================================
+ Hits 48330 48332 +2
- Misses 7919 7925 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
force-pushed
the
alamb/serialize_interval_mdn
branch
2 times, most recently
from
7bb0b9f
to
81c0b54
Compare
| @@ -422,6 +425,23 @@ mod roundtrip_tests { | |||
| ScalarValue::TimestampSecond(Some(i64::MAX), None), | |||
| ScalarValue::TimestampSecond(Some(0), Some("UTC".to_string())), | |||
| ScalarValue::TimestampSecond(None, None), | |||
| ScalarValue::IntervalDayTime(Some(IntervalDayTimeType::make_value(0, 0))), | |||
There was a problem hiding this comment.
It appears there were no round trip tests for IntervalDayTime either, so I added them as well
|
|
||
| message ScalarValue{ | ||
| oneof value { | ||
| // Null value of any type (type is encoded) | ||
| PrimitiveScalarType null_value = 19; |
There was a problem hiding this comment.
I really dislike PrimitiveScalarType and hope to remove it eventually
|
cc @waitingkuo and @avantgardnerio |
alamb
force-pushed
the
alamb/serialize_interval_mdn
branch
from
81c0b54
to
0a1fbee
Compare
|
LGTM thank you @alamb |
|
Benchmark runs are scheduled for baseline = 7033c0e and contender = 52ff7ca. 52ff7ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
draft as it builds on #3534Which issue does this PR close?
Part of #3531
Rationale for this change
See #3531
What changes are included in this PR?
ScalarValue::IntervalMonthDayNanoAre there any user-facing changes?
No