Add serialization of ScalarValue::Struct
#3536
Conversation
alamb
force-pushed
the
alamb/serialize_struct
branch
from
9a28f02 to
1c7b3fe
Compare
alamb
force-pushed
the
alamb/serialize_struct
branch
from
1c7b3fe to
cc2b408
Compare
| @@ -739,6 +739,13 @@ message IntervalMonthDayNanoValue { | |||
| int64 nanos = 3; | |||
| } | |||
|
|
|||
| message StructValue { | |||
| // encode null explicitly to distinguish a struct with no fields (is | |||
There was a problem hiding this comment.
If there are no fields there can't be any values, null or otherwise? I therefore think we could drop this?
There was a problem hiding this comment.
I will try and remove it
There was a problem hiding this comment.
Added an assert that there are always at least one Field / value and removed explicit support is_null in 88370bf
|
Benchmark runs are scheduled for baseline = 41b59cf and contender = b4c0601. b4c0601 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Draft as it builds on #3535Which issue does this PR close?
Closes #3531
Rationale for this change
See #3531
What changes are included in this PR?
Changes:
ScalarValue::StructAre there any user-facing changes?
No