Fix "Projection references non-aggregate values" by updating rebase_expr to use transform_down
#8890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
rebase_expr by using transform_up
alamb
changed the title
rebase_expr by using transform_uprebase_expr by using transform_down
9 tasks
|
@alamb This is not just performance, but also correctness, see my comment in #8280 (comment) |
Thanks @wizardxz -- I have updated the PR title and also made #8898 so it was clearer that this is correctness as well |
alamb
changed the title
rebase_expr by using transform_downrebase_expr to use transform_down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8280
Closes #8898
Rationale for this change
rebase_expr should strive to re-base on the outermost available base expression in order to minimize (however negligible) the computation that needs to be done on top of it.
What changes are included in this PR?
rebase_expr()
Are these changes tested?
Yes
Are there any user-facing changes?
No