Minor: Move function signature check to planning stage #9401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
SteveLauC
reviewed
Feb 29, 2024
Comment on lines
+143
to
+152
| data_types(&arg_data_types, fun.signature()).map_err(|_| { | ||
| plan_datafusion_err!( | ||
| "{}", | ||
| utils::generate_signature_error_msg( | ||
| fun.name(), | ||
| fun.signature().clone(), | ||
| &arg_data_types, | ||
| ) | ||
| ) | ||
| })?; |
comphead
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
lgtm thanks @2010YOUY01
Thats good start to unify error messages if signature cannot be found
alamb
reviewed
Feb 29, 2024
| @@ -84,7 +84,7 @@ statement error Error during planning: No function matches the given name and ar | |||
| SELECT concat(); | |||
|
|
|||
| # error message for wrong function signature (Uniform: t args all from some common types) | |||
| statement error DataFusion error: Failed to coerce arguments for NULLIF | |||
| statement error DataFusion error: Error during planning: No function matches the given name and argument types 'nullif\(Int64\)'. You might need to add explicit type casts. | |||
There was a problem hiding this comment.
That is a much nicer error message
alamb
approved these changes
Feb 29, 2024
|
Let me merge this nice change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NA
Rationale for this change
I noticed a recent PR #9377 tried to check function argument number inside a specific function's implementation
It can be done at a higher level during planning (as it was in old builtin function implementation)
What changes are included in this PR?
Are these changes tested?
Covered by existing test introduced in #9377
Are there any user-facing changes?
No