Port tan, tanh to datafusion-functions #9535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jonahgao
reviewed
Mar 11, 2024
datafusion/functions/src/math/tan.rs
Outdated
| } | ||
|
|
||
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | ||
| if arg_types.len() != 1 { |
There was a problem hiding this comment.
I think this is a duplication with #9401, we can remove it, or use a simple internal_err.
jonahgao
reviewed
Mar 11, 2024
|
|
||
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | ||
| if arg_types.len() != 1 { | ||
| return Err(plan_datafusion_err!( |
jonahgao
approved these changes
Mar 11, 2024
ongchi
commented
Mar 11, 2024
Comment on lines
+38
to
+42
| signature: Signature::uniform( | ||
| 1, | ||
| vec![DataType::Float64, DataType::Float32], | ||
| Volatility::Immutable, | ||
| ), |
There was a problem hiding this comment.
Except for the
generate_signature_error_msg, everything else looks good to me!
I'm thinking about if the signature has a fixed number of args to 1, is it safe to ignore length checking of arg_types in ScalarUDFImpl::return_type? So the error message generation could be eliminated.
There was a problem hiding this comment.
I think it's safe, that's exactly what was done in PR 9401. We can verify it through a test in sqllogictest.
|
I merged up from main to resolve conflicts on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9285
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?