Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] optimize #3165 Gets the value of this property “resource.storage.type”, Comparison with enumerated types #3176

Closed
felix-thinkingdata opened this issue Jul 10, 2020 · 1 comment · Fixed by #3178
Labels
bug Something isn't working enhancement New feature or request

Comments

@felix-thinkingdata
Copy link
Contributor

felix-thinkingdata commented Jul 10, 2020

By looking at the ResourcesService code, I found a potential problem.

Enumeration type comparisons are used in both classes :HadoopUtils.java ,CommonUtils.java

I don't think this submission is perfect

All comparisons of ResUploadType need to be optimized.

I'm going to modify this part

中文:

通过阅读ResourcesService代码,发现了潜在隐患。

在HadoopUtils和CommonUtils,资源中心类型,都是通过枚举类型比较。

所以感觉到submission 这个提交是不完备的。

需要优化所有的ResUploadType类型比较部分的代码。

@yangyichao-mango
Copy link
Contributor

Hi,
Please modify the issue content according to the template specification when creating the issue, it can help us locate the problem more quickly.

And can you describe
1.what kind of bug will it lead to at present
2.what kind of potential problem exist

Issue content template as follow:

*For better global communication, please give priority to using English description, thx! *

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior, for example:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.


**Which version of Dolphin Scheduler:**
 -[1.1.0-preview]

**Additional context**
Add any other context about the problem here.

**Requirement or improvement
- Please describe about your requirements or improvement suggestions.

lgcareer pushed a commit that referenced this issue Jul 10, 2020
…”, Comparison with enumerated types (#3178)

* fix bug #3165   get resource.storage.type value   toUpperCase

* fix bug #3176  optimize Gets the value of this property “resource.storage.type”

Co-authored-by: dailidong <dailidong66@gmail.com>
qiaozhanwei pushed a commit that referenced this issue Aug 10, 2020
…get the application status, you cannot get it if Kerberos authentication is enabled (#3264)

* fix bug #3165   get resource.storage.type value   toUpperCase

* fix bug #3176  optimize Gets the value of this property “resource.storage.type”

* fix When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled

* fix When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled

* fix When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled

* fix miss

* add KerberosHttpClient fix  kerberos bug

* fix map init

* add juint test

* Extraction of public methods

* Extraction of public methods

* Fix code quality

* Fix code quality

* Fix code quality

* Fix code quality

* Fix code quality

* Fix code quality

* Fix code quality

* rebuild test

* rebuild test

* check style

* check style

* check style

* revert UT POM

* Kerberos judgment goes up to hadoopUtils

* fix merge

* Remove connection pool shutdown

Co-authored-by: dailidong <dailidong66@gmail.com>
@qiaozhanwei qiaozhanwei added the enhancement New feature or request label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants