[Fix-3262][common] When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.storage.type”
…tion status, you cannot get it if Kerberos authentication is enabled
…tion status, you cannot get it if Kerberos authentication is enabled
…tion status, you cannot get it if Kerberos authentication is enabled
Codecov Report
@@ Coverage Diff @@
## dev #3264 +/- ##
============================================
- Coverage 34.54% 34.37% -0.17%
Complexity 2464 2464
============================================
Files 443 444 +1
Lines 20641 20739 +98
Branches 2532 2541 +9
============================================
Hits 7130 7130
- Misses 12849 12946 +97
- Partials 662 663 +1
Continue to review full report at Codecov.
|
|
Hi, Please change the title according to the pr specifications[1]. Thx a lot~ [1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html |
|
ok
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月22日(周三) 12:42
主题: Re: [apache/incubator-dolphinscheduler] fix bug #3262 When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Hi,
Please change the title according to the pr specifications[1]. Thx a lot~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
felix-thinkingdata
changed the title
|
Please add test case code the for new code, sonar request 33.3% coverage for new code. |
|
Is that ok？
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月22日(周三) 14:07
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Please add test case code the for new code, sonar request 33.3% coverage for new code.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
The code format changes have been completed ，Please check the code for me again，thank you |
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java
Outdated
Show resolved
Hide resolved
|
Hi, |
...eduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java
Show resolved
Hide resolved
|
Should I continue to optimize my patch or create a new patch?
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 19:49
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Hi,
Good job,
I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hi~, |
|
ok, I can do singleton model optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao Yangnotifications@github.com 收件人: apache/incubator-dolphinschedulerincubator-dolphinscheduler@noreply.github.com 抄送: felix.wangfelix@thinkingdata.cn; State changestate_change@noreply.github.com 发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
原始邮件
发件人: felix<felix@thinkingdata.cn>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>; apache/incubator-dolphinscheduler<reply@reply.github.com>
抄送: State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 22:03
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
ok, I can do singleton model optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao Yangnotifications@github.com 收件人: apache/incubator-dolphinschedulerincubator-dolphinscheduler@noreply.github.com 抄送: felix.wangfelix@thinkingdata.cn; State changestate_change@noreply.github.com 发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
中文：
支持https 是指，在使用自建证书的情况下，也可以通过https url访问。一般自建证书程序会认为非安全会报错。
原始邮件
发件人: felix<felix@thinkingdata.cn>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>; apache/incubator-dolphinscheduler<reply@reply.github.com>
抄送: State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 22:07
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
原始邮件
发件人: felix<felix@thinkingdata.cn>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>; apache/incubator-dolphinscheduler<reply@reply.github.com>
抄送: State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 22:03
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
ok, I can do singleton model optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao Yang<notifications@github.com>
收件人: apache/incubator-dolphinscheduler<incubator-dolphinscheduler@noreply.github.com>
抄送: felix.wang<felix@thinkingdata.cn>; State change<state_change@noreply.github.com>
发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao Yangnotifications@github.com 收件人: apache/incubator-dolphinschedulerincubator-dolphinscheduler@noreply.github.com 抄送: felix.wangfelix@thinkingdata.cn; State changestate_change@noreply.github.com 发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug][dolphinscheduler-common] When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled #3262
Tips
Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.
What is the purpose of the pull request
fix #3262