Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test][api] Improvement DataSourceServiceTest #3558

Closed
yangyichao-mango opened this issue Aug 19, 2020 · 2 comments · Fixed by #3579
Closed

[Test][api] Improvement DataSourceServiceTest #3558

yangyichao-mango opened this issue Aug 19, 2020 · 2 comments · Fixed by #3579

Comments

@yangyichao-mango
Copy link
Contributor

yangyichao-mango commented Aug 19, 2020 •
edited
Loading

Describe the question
Improvement the DataSourceServiceTest test case for DataSourceService for full coverage (100% method coverage).

Test case example
https://github.com/apache/incubator-dolphinscheduler/blob/dev/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionServiceTest.java

Test case specifications
https://dolphinscheduler.apache.org/zh-cn/docs/development/unit-test.html
Important: Need to improvement the test case according to the specifications

Which version of DolphinScheduler:
-[dev]
@yangyichao-mango yangyichao-mango changed the title [Test][api] Improvement DataSourceServiceTest [Test][api] Improvement DataSourceServiceTest Aug 19, 2020
@yangyichao-mango
Copy link
Contributor Author

Anyone who want to take it, welcome to leave a message~

@yangyichao-mango yangyichao-mango mentioned this issue Aug 20, 2020
Closed
This was referenced Aug 20, 2020
Closed
Closed
@yy0812
Copy link
Contributor

yy0812 commented Aug 21, 2020

I will take [Test-3558] to write the unittest to full coverage.

@yy0812 yy0812 mentioned this issue Aug 21, 2020
Closed
@yangyichao-mango yangyichao-mango mentioned this issue Aug 21, 2020
Closed
This was referenced Aug 24, 2020
Closed
Merged
@davidzollo davidzollo linked a pull request Aug 24, 2020 that will close this issue
[Improvement-3558][API] Improve DataSourceServiceTest.java #3579
Merged
davidzollo pushed a commit that referenced this issue Aug 24, 2020
@yy0812
[Improvement-3558][API] Improve DataSourceServiceTest.java (#3579)
78eb07b 
* Fixed this bug "multiple threads creating folders will result in multiple identical folders" #3487

* 1. Improvement `DataSourceServiceTest` #3558
2. Get rid of some useless arguments to functions in the `DataSourceService` class

* The rollback `ResourceService.java`

* The rollback `ResourceService.java`

* The rollback `ResourceService.java`

* 1.Modify code styles.
2.Make improvement according to Yichao Yang's advice. Thank you very much for guidance.@yichao Yang

* Modify code styles.

* Circumventing the checkConnection problem

* Modify code styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Improvement-3558][API] Improve DataSourceServiceTest.java
2 participants
@yangyichao-mango @yy0812