Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](merge-on-write) move segment check to delta writer #18643

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[improvement](merge-on-write) move segment check to delta writer #18643

merged 1 commit into from
Apr 17, 2023

Conversation

yixiutt
Copy link
Contributor

@yixiutt yixiutt commented Apr 13, 2023

Proposed changes

calc delete bitmap among segments in delta writer, so publish will not get timeout

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yixiutt
Copy link
Contributor Author

yixiutt commented Apr 13, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 13, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.6 seconds
stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417030821_clickbench_pr_129852.html

liaoxin01
liaoxin01 reviewed Apr 14, 2023
View reviewed changes
be/src/olap/delta_writer.cpp Outdated Show resolved Hide resolved
be/src/olap/delta_writer.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yixiutt
Copy link
Contributor Author

yixiutt commented Apr 14, 2023

run buildall

1 similar comment
@yixiutt
Copy link
Contributor Author

yixiutt commented Apr 14, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yixiutt
Copy link
Contributor Author

yixiutt commented Apr 17, 2023

run buildall

1 similar comment
@yixiutt
Copy link
Contributor Author

yixiutt commented Apr 17, 2023

run buildall

zhannngchen
zhannngchen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhannngchen zhannngchen merged commit b458c14 into apache:master Apr 17, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@yixiutt @gnehil
[improvement](merge-on-write) move segment check to delta writer (apa…
aaf75bb 
…che#18643)
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
@yixiutt @Reminiscent
[improvement](merge-on-write) move segment check to delta writer (apa…
2d1a3e0 
…che#18643)
zhannngchen pushed a commit to zhannngchen/incubator-doris that referenced this pull request Jun 6, 2023
@yixiutt @zhannngchen
[improvement](merge-on-write) move segment check to delta writer (apa…
bdb66e8 
…che#18643)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
@yixiutt
[improvement](merge-on-write) move segment check to delta writer (apa…
1c03a7d 
…che#18643)
@liaoxin01 liaoxin01 mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoxin01 liaoxin01 liaoxin01 left review comments

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.4 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yixiutt @hello-stephen @liaoxin01 @zhannngchen @morningman