Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](meger-on-write) fix query result wrong when schema change #22044

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem:

  1. failed to initialize storage reader. tablet=40321.1191259674.1f4189c7184f58ad-15f3320801a27cb0, res=[INTERNAL_ERROR]fail to find path in version_graph. spec_version: 0-45
  2. duplicate key in result set

Why:

  1. when tablet in converting,we don't commit the rowset just return it. So the rowset cann't be publushed, we can't find it in the version graph. this was introduced by: [improvement](merge-on-write) move segment check to delta writer #18643
        if (_tablet->tablet_state() == TABLET_NOTREADY &&
            SchemaChangeHandler::tablet_in_converting(_tablet->tablet_id())) {
            return Status::OK();
        }
  1. when tablet in converting, we should clear _rowset_ids. Otherwise, we will calculate the delete bitmap incorrectly when publish.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Jul 20, 2023
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45 seconds
stream load tsv: 510 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162507721 Bytes

Copy link
Collaborator

@Yukang-Lian Yukang-Lian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 marked this pull request as draft July 21, 2023 01:54
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 21, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@liaoxin01 liaoxin01 marked this pull request as ready for review July 21, 2023 03:33
@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.19 seconds
stream load tsv: 506 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17169253700 Bytes

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 21, 2023
@dataroaring dataroaring merged commit db69af1 into apache:master Jul 21, 2023
19 of 21 checks passed
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Jul 21, 2023
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 22, 2023
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jul 31, 2023
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jul 31, 2023
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Aug 27, 2023
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Aug 27, 2023
morningman pushed a commit that referenced this pull request Aug 28, 2023
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@liaoxin01 liaoxin01 deleted the fix_sc_mow branch February 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants