Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](transaction) abort txn after be lost heartbeat over 1 min #22781

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[improvement](transaction) abort txn after be lost heartbeat over 1 min #22781

merged 1 commit into from
Aug 10, 2023

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Aug 9, 2023 •
edited
Loading

Proposed changes

Default heartbeat failure time is 5s, it's too sensitive to abort a txn.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Collaborator Author

yujun777 commented Aug 9, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.02 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162223622 Bytes

dataroaring
dataroaring approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

PR approved by anyone and no changes requested.

kaijchen
kaijchen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hard-coded value could be a config.

@dataroaring dataroaring merged commit 35dd787 into apache:master Aug 10, 2023
18 of 20 checks passed
@wm1581066 wm1581066 added the usercase Important user case type label label Aug 12, 2024
yujun777 added a commit to yujun777/doris that referenced this pull request Aug 13, 2024
@yujun777
[improvement](transaction) abort txn when be lost heartbeat over 1 min (
c7353a0 
apache#22781)
@yujun777 yujun777 mentioned this pull request Aug 13, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 14, 2024
@yujun777 @sollhui
[branch-2.0](txn) be dead exceeds 5min abort its txns (#22781, #28662, …
eaffb69 
…#35342) (#39317)

cherry-pick:  #22781,  #28662, #35342

---------

Co-authored-by: HHoflittlefish777 <77738092+HHoflittlefish777@users.noreply.github.com>
@xiaokang xiaokang mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaijchen kaijchen kaijchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yujun777 @hello-stephen @kaijchen @dataroaring @liaoxin01 @wm1581066