[fix](txn) Fix coordidator be restart not abort txn #35342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
924060929
previously approved these changes
May 24, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40765 ms |
TPC-DS: Total hot run time: 172652 ms |
ClickBench: Total hot run time: 30.08 s |
|
TeamCity be ut coverage result: |
|
run p0 |
dataroaring
requested changes
May 27, 2024
| @@ -174,6 +175,7 @@ Status StreamLoadExecutor::begin_txn(StreamLoadContext* ctx) { | |||
| request.__set_timeout(ctx->timeout_second); | |||
| } | |||
| request.__set_request_id(ctx->id.to_thrift()); | |||
| request.__set_backend_id(_exec_env->master_info()->backend_id); | |||
|
|
|||
There was a problem hiding this comment.
httpstream shoud also be considered.
There was a problem hiding this comment.
had fix httpstream
github-actions
bot
removed
the
approved
|
yujun777
force-pushed
the
coordidator-be-restart-abort-txn
branch
from
0dc1c1d
to
7adb998
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 41105 ms |
TPC-DS: Total hot run time: 172354 ms |
ClickBench: Total hot run time: 30.4 s |
|
TeamCity be ut coverage result: |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 40701 ms |
TPC-DS: Total hot run time: 173546 ms |
ClickBench: Total hot run time: 30.97 s |
|
TeamCity be ut coverage result: |
dataroaring
reviewed
Jun 13, 2024
| @SerializedName(value = "ip") | ||
| public String ip; | ||
| // frontend/backend start time | ||
| @SerializedName(value = "startTime") |
There was a problem hiding this comment.
short name is preferred, like st.
yujun777
force-pushed
the
coordidator-be-restart-abort-txn
branch
from
03abb17
to
daf6f98
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 40520 ms |
TPC-DS: Total hot run time: 174151 ms |
ClickBench: Total hot run time: 30.55 s |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
BUG: fe will abort coordidator BE's txn when be shutdown exceeds 5min. But if BE restart within 5min, then this BE's txns will not abort until timeout. FIX: every txn will record BE's id and its start time. When fe found be's startTime change, it will abort the BE's old txns.
dataroaring
pushed a commit
that referenced
this pull request
Jun 25, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: fe will abort coordidator BE's txn when be shutdown exceeds 5min. But if BE restart within 5min, then this BE's txns will not abort until timeout.
FIX: every txn will record BE's id and its start time. When fe found be's startTime change, it will abort the BE's old txns.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...