[nereids](topn-filter) support multi-topn filter (FE part) #31485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
englefly
changed the title
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37960 ms |
TPC-DS: Total hot run time: 168890 ms |
ClickBench: Total hot run time: 32.91 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38016 ms |
TPC-DS: Total hot run time: 170045 ms |
ClickBench: Total hot run time: 32.47 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run feut |
englefly
changed the title
morrySnow
reviewed
Feb 29, 2024
Contributor
morrySnow
left a comment
morrySnow
left a comment
There was a problem hiding this comment.
add enough test cases please
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
englefly
changed the title
englefly
force-pushed
the
topn-ext
branch
3 times, most recently
from
b9d47cb to
b64e281
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38314 ms |
TPC-DS: Total hot run time: 176855 ms |
ClickBench: Total hot run time: 31.91 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37885 ms |
TPC-DS: Total hot run time: 187179 ms |
ClickBench: Total hot run time: 31.17 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38076 ms |
TPC-DS: Total hot run time: 186315 ms |
ClickBench: Total hot run time: 31.34 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
starocean999
approved these changes
Mar 11, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Mar 11, 2024
16 tasks
englefly
added a commit
that referenced
this pull request
Jan 8, 2025
…ode (#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
…ode (#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Jan 8, 2025
…ode (apache#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: apache#31485 (cherry picked from commit 811f936)
16 tasks
englefly
added a commit
that referenced
this pull request
Jan 8, 2025
…ode (#46551) (branch-3.0) (#46585) pick#46551 ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485 (cherry picked from commit 811f936)
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Mar 28, 2025
…y instead of Topn node apache#46551 (apache#3800) pick apache#46551 ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: apache#31485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
in previous version, topN should be the parent of scan. this restriction is removed.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...