Skip to content

Conversation

@wfjcmcb
Copy link
Contributor

@wfjcmcb wfjcmcb commented Jun 8, 2020

This plugin is used to output data to Doris for logstash
Use the HTTP protocol to interact with the Doris FE Http interface
Load data through Doris's stream load
#3809

@morningman morningman self-assigned this Jun 8, 2020
@morningman
Copy link
Contributor

Good work!

Please add English doc ~

@morningman morningman added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 9, 2020
@@ -0,0 +1,198 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this doc title in the side bar:
open the docs/.vuepress/sidebar/en.js and search extending-doris/

@@ -0,0 +1,198 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this doc title in the side bar:
open the docs/.vuepress/sidebar/zh-CN.js and search 扩展功能

Gem::Specification.new do |s|
s.name = 'logstash-output-doris'
s.version = '0.1.0'
s.licenses = ['Apache License (2.0)']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache License (2.0) seems not a valid license name in my env.
Should it be Apache-2.0

s.add_runtime_dependency 'mini_cache', ">= 1.0.0", "< 2.0.0"
s.add_runtime_dependency "rest-client", '>= 1.8.0'

s.add_development_dependency 'logstash-devutils'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add version info for following 3 dependencies

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/logstash Issues or PRs related to logstash extension release-note labels Jun 10, 2020
@morningman morningman merged commit 86d235a into apache:master Jun 11, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Aug 17, 2020
csun5285 pushed a commit to csun5285/doris that referenced this pull request Mar 28, 2025
…y instead of Topn node apache#46551 (apache#3800)

pick apache#46551

### What problem does this PR solve?
Plan node is not good to be hash map key, because two plan nodes in
different tree level may be regarded as "equal". for example, in
following tree, topn1.equals(topn2) may be true.
 Topn filter generator should distinguish them, and hence topn
node is not suitable to be used as hash map key.

topn1
    -->some node
        -->topn2
             -->other node

Related PR: apache#31485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/logstash Issues or PRs related to logstash extension kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants