[featrue](expr) support common subexpression elimination be part #32673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // input expr -> intermediate_projections[0] -> intermediate_projections[1] -> intermediate_projections[2] ... -> final projections -> output expr | ||
| // prepare _row_descriptor intermediate_row_desc[0] intermediate_row_desc[1] intermediate_row_desc.end() _output_row_descriptor | ||
|
|
||
| [[nodiscard]] const RowDescriptor& projections_row_desc() const { |
Contributor
There was a problem hiding this comment.
warning: method 'projections_row_desc' can be made static [readability-convert-member-functions-to-static]
Suggested change
| [[nodiscard]] const RowDescriptor& projections_row_desc() const { | |
| [[nodiscard]] static const RowDescriptor& projections_row_desc() { |
| // input expr -> intermediate_projections[0] -> intermediate_projections[1] -> intermediate_projections[2] ... -> final projections -> output expr | ||
| // prepare _row_descriptor intermediate_row_desc[0] intermediate_row_desc[1] intermediate_row_desc.end() _output_row_descriptor | ||
|
|
||
| [[nodiscard]] const RowDescriptor& projections_row_desc() const { |
Contributor
There was a problem hiding this comment.
warning: method 'projections_row_desc' can be made static [readability-convert-member-functions-to-static]
Suggested change
| [[nodiscard]] const RowDescriptor& projections_row_desc() const { | |
| [[nodiscard]] static const RowDescriptor& projections_row_desc() { |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38346 ms |
TPC-DS: Total hot run time: 181939 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
| } | ||
| } | ||
|
|
||
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { |
Contributor
There was a problem hiding this comment.
warning: method 'intermediate_row_desc' can be made const [readability-make-member-function-const]
Suggested change
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { | |
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const { |
| } | ||
| } | ||
|
|
||
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { |
Contributor
There was a problem hiding this comment.
warning: method 'intermediate_row_desc' can be made const [readability-make-member-function-const]
Suggested change
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { | |
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const { |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38076 ms |
TPC-DS: Total hot run time: 187172 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37727 ms |
TPC-DS: Total hot run time: 186464 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
englefly
previously approved these changes
Mar 25, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
HappenLee
reviewed
Mar 27, 2024
be/src/vec/exec/scan/vscanner.cpp
Outdated
|
|
||
| vectorized::Block input_block = *origin_block; | ||
|
|
||
| const size_t rows = input_block.rows(); |
Contributor
There was a problem hiding this comment.
do the check before copy *origin_block
HappenLee
reviewed
Mar 27, 2024
| } | ||
|
|
||
| void Block::shuffle_columns(std::vector<int>& result_column_ids) { | ||
| Container tmp_data; |
Contributor
There was a problem hiding this comment.
tmp_data(result_column_ids.size())
HappenLee
reviewed
Mar 27, 2024
be/src/vec/core/block.cpp
Outdated
| row_same_bit = std::move(other.row_same_bit); | ||
| } | ||
|
|
||
| void Block::shuffle_columns(std::vector<int>& result_column_ids) { |
HappenLee
reviewed
Mar 27, 2024
be/src/exec/exec_node.h
Outdated
| std::unique_ptr<RowDescriptor> _output_row_descriptor; | ||
| vectorized::VExprContextSPtrs _projections; | ||
|
|
||
| std::vector<std::unique_ptr<RowDescriptor>> _intermediate_output_row_descriptor; |
Contributor
There was a problem hiding this comment.
why here need unique_ptr ? not std::vector
recheck the logic:_output_row_descriptor
Contributor
Author
There was a problem hiding this comment.
_output_row_descriptor needs to be a pointer because it could be null, null means that no projection is required.
HappenLee
reviewed
Mar 27, 2024
be/src/exec/exec_node.cpp
Outdated
| } | ||
| _projections = _intermediate_projections.back(); | ||
| _intermediate_projections.pop_back(); | ||
|
|
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38575 ms |
TPC-DS: Total hot run time: 182097 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Gabriel39
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fe code #32004
test pr #32770
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...