[only test] " [featrue](expr) support common subexpression elimination" #32770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // input expr -> intermediate_projections[0] -> intermediate_projections[1] -> intermediate_projections[2] ... -> final projections -> output expr | ||
| // prepare _row_descriptor intermediate_row_desc[0] intermediate_row_desc[1] intermediate_row_desc.end() _output_row_descriptor | ||
|
|
||
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { |
Contributor
There was a problem hiding this comment.
warning: method 'intermediate_row_desc' can be made const [readability-make-member-function-const]
Suggested change
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { | |
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const { |
| // input expr -> intermediate_projections[0] -> intermediate_projections[1] -> intermediate_projections[2] ... -> final projections -> output expr | ||
| // prepare _row_descriptor intermediate_row_desc[0] intermediate_row_desc[1] intermediate_row_desc.end() _output_row_descriptor | ||
|
|
||
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { |
Contributor
There was a problem hiding this comment.
warning: method 'intermediate_row_desc' can be made const [readability-make-member-function-const]
Suggested change
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) { | |
| [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const { |
TPC-H: Total hot run time: 38575 ms |
TPC-DS: Total hot run time: 186553 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37916 ms |
TPC-DS: Total hot run time: 181743 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run external |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38203 ms |
TPC-DS: Total hot run time: 181414 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38329 ms |
TPC-DS: Total hot run time: 182845 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 29.65 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...