[bugfix](hive)fix error for writing to hive for 2.1 #34518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
wuwenchi
changed the title
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
wsjz
reviewed
May 8, 2024
| if (idx != string::npos) { | ||
| idx = path.find("/", idx + 3); | ||
| if (idx != string::npos) { | ||
| hdfs_params.fs_name = path.substr(0, idx); |
Contributor
There was a problem hiding this comment.
give a comment to show that parse fs_name from hdfs://host:port and hdfs://dfsnameservice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
mirror #34520
When the nameserver specified by
defaultFSis different from the nameserver of the actual table, write failure may occur.Moreover, when the orc writing fails, it still goes to the commit process (actually, after the writing fails, FE should be able to get the error message from BE, and should not go to the commit process)
Fix:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...