Skip to content

Conversation

@wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented May 8, 2024

Proposed changes

When the nameserver specified by defaultFS is different from the nameserver of the actual table, write failure may occur.
Moreover, when the orc writing fails, it still goes to the commit process (actually, after the writing fails, FE should be able to get the error message from BE, and should not go to the commit process)

Fix:

  1. When orc writing fails, an exception is thrown. The upstream captures the exception and returns it to status for FE to obtain.
  2. When creating fs in the writing process, if the writing path contains a nameserver, then use this nameserver directly to create fs. (In this way, when writing to hive, there is no need to configure defaultFS in the catalog)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

wuwenchi commented May 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wuwenchi
Copy link
Contributor Author

wuwenchi commented May 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman previously approved these changes May 8, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.68% (8981/25170)
Line Coverage: 27.33% (74186/271410)
Region Coverage: 26.57% (38346/144339)
Branch Coverage: 23.39% (19560/83624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1ee2a0bc91ffe4b945fa45a7f64e6059fd47fd8c_1ee2a0bc91ffe4b945fa45a7f64e6059fd47fd8c/report/index.html

@wuwenchi
Copy link
Contributor Author

wuwenchi commented May 8, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (8983/25170)
Line Coverage: 27.35% (74226/271410)
Region Coverage: 26.58% (38370/144339)
Branch Coverage: 23.41% (19573/83624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec8f8fe8e5a188e9b877b92eda0bea4b29efeb15_ec8f8fe8e5a188e9b877b92eda0bea4b29efeb15/report/index.html

morningman
morningman previously approved these changes May 10, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2024
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuwenchi
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 14, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.67% (8982/25180)
Line Coverage: 27.33% (74262/271758)
Region Coverage: 26.56% (38372/144455)
Branch Coverage: 23.39% (19575/83704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5f68d81dbf32bb0cb8d32193e8d9b742e49181c4_5f68d81dbf32bb0cb8d32193e8d9b742e49181c4/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 14, 2024
@morningman morningman merged commit f91c209 into apache:master May 14, 2024
morningman added a commit that referenced this pull request Apr 19, 2025
…49998)

### What problem does this PR solve?

In this PR #34520, we only handle HivePartitionWriter. But this should
be applied to all hdfs writer.
This PR fix it, unify the logic to make it work with both hive and
iceberg writer.

If the path is an absolute full path like `hdfs://host/path/to/file`,
use `hdfs://host/` as fs name,
otherwise, use default fs name.
github-actions bot pushed a commit that referenced this pull request Apr 19, 2025
…49998)

### What problem does this PR solve?

In this PR #34520, we only handle HivePartitionWriter. But this should
be applied to all hdfs writer.
This PR fix it, unify the logic to make it work with both hive and
iceberg writer.

If the path is an absolute full path like `hdfs://host/path/to/file`,
use `hdfs://host/` as fs name,
otherwise, use default fs name.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…pache#49998)

### What problem does this PR solve?

In this PR apache#34520, we only handle HivePartitionWriter. But this should
be applied to all hdfs writer.
This PR fix it, unify the logic to make it work with both hive and
iceberg writer.

If the path is an absolute full path like `hdfs://host/path/to/file`,
use `hdfs://host/` as fs name,
otherwise, use default fs name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants