-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](hive/iceberg) rectify the fs name if path already contains fs #49998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34132 ms |
TPC-DS: Total hot run time: 193025 ms |
ClickBench: Total hot run time: 31.55 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34322 ms |
TPC-DS: Total hot run time: 192136 ms |
ClickBench: Total hot run time: 31.07 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…49998) ### What problem does this PR solve? In this PR #34520, we only handle HivePartitionWriter. But this should be applied to all hdfs writer. This PR fix it, unify the logic to make it work with both hive and iceberg writer. If the path is an absolute full path like `hdfs://host/path/to/file`, use `hdfs://host/` as fs name, otherwise, use default fs name.
…pache#49998) ### What problem does this PR solve? In this PR apache#34520, we only handle HivePartitionWriter. But this should be applied to all hdfs writer. This PR fix it, unify the logic to make it work with both hive and iceberg writer. If the path is an absolute full path like `hdfs://host/path/to/file`, use `hdfs://host/` as fs name, otherwise, use default fs name.
What problem does this PR solve?
In this PR #34520, we only handle HivePartitionWriter. But this should be applied to all hdfs writer.
This PR fix it, unify the logic to make it work with both hive and iceberg writer.
If the path is an absolute full path like
hdfs://host/path/to/file, usehdfs://host/as fs name,otherwise, use default fs name.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)