Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented May 13, 2024

Proposed changes

support deletion vector for Paimon naive reader

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223 suxiaogang223 force-pushed the paimon_deletion_vector branch from 726486a to fcb9e1e Compare May 15, 2024 07:34
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@suxiaogang223
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.68% (9004/25233)
Line Coverage: 27.36% (74488/272277)
Region Coverage: 26.60% (38511/144784)
Branch Coverage: 23.43% (19645/83862)
Coverage Report: http://coverage.selectdb-in.cc/coverage/46411e10c217eb6457a62c1a38c5e62a36798404_46411e10c217eb6457a62c1a38c5e62a36798404/report/index.html

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.67% (9003/25239)
Line Coverage: 27.35% (74490/272328)
Region Coverage: 26.60% (38521/144799)
Branch Coverage: 23.43% (19655/83872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/46411e10c217eb6457a62c1a38c5e62a36798404_46411e10c217eb6457a62c1a38c5e62a36798404/report/index.html

@AshinGau
Copy link
Member

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman force-pushed the paimon_deletion_vector branch from 46411e1 to f39a510 Compare May 19, 2024 14:39
@morningman
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (9008/25242)
Line Coverage: 27.35% (74502/272394)
Region Coverage: 26.59% (38531/144885)
Branch Coverage: 23.43% (19663/83920)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f39a510abda2fd1f788aeb0fa3ffe1a2e8ff627d_f39a510abda2fd1f788aeb0fa3ffe1a2e8ff627d/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshinGau AshinGau merged commit 1a5933c into apache:master May 20, 2024
morningman pushed a commit to morningman/doris that referenced this pull request May 22, 2024
morningman added a commit that referenced this pull request May 22, 2024
…4743) (#35241)

bp #34743
Co-authored-by: 苏小刚 <suxiaogang223@icloud.com>
dataroaring pushed a commit that referenced this pull request May 26, 2024
@suxiaogang223 suxiaogang223 deleted the paimon_deletion_vector branch August 15, 2024 08:49
morningman pushed a commit that referenced this pull request Apr 2, 2025
…49645)

### What problem does this PR solve?
Related PR: #34743 

Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
github-actions bot pushed a commit that referenced this pull request Apr 2, 2025
…49645)

### What problem does this PR solve?
Related PR: #34743 

Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
github-actions bot pushed a commit that referenced this pull request Apr 2, 2025
…49645)

### What problem does this PR solve?
Related PR: #34743 

Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…pache#49645)

### What problem does this PR solve?
Related PR: apache#34743 

Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged meta-change reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants