-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](Paimon) support deletion vector for Paimon naive reader #34743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](Paimon) support deletion vector for Paimon naive reader #34743
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
726486a to
fcb9e1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
LGTM |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
46411e1 to
f39a510
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ache#34743) support deletion vector for Paimon naive reader
…4743) support deletion vector for Paimon naive reader
…49645) ### What problem does this PR solve? Related PR: #34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
…49645) ### What problem does this PR solve? Related PR: #34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
…49645) ### What problem does this PR solve? Related PR: #34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
…pache#49645) ### What problem does this PR solve? Related PR: apache#34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
Proposed changes
support deletion vector for Paimon naive reader
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...