-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe #49645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34938 ms |
TPC-DS: Total hot run time: 192583 ms |
ClickBench: Total hot run time: 31.25 s |
d5ffd73 to
e2dfb37
Compare
|
run buildall |
TPC-H: Total hot run time: 34229 ms |
TPC-DS: Total hot run time: 185883 ms |
ClickBench: Total hot run time: 31.24 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34197 ms |
TPC-DS: Total hot run time: 186252 ms |
ClickBench: Total hot run time: 31.41 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…49645) ### What problem does this PR solve? Related PR: #34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
…49645) ### What problem does this PR solve? Related PR: #34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
…pache#49645) ### What problem does this PR solve? Related PR: apache#34743 Problem Summary: The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
What problem does this PR solve?
Related PR: #34743
Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://' prefix to BE, which cannot recognize this URL format. The solution is to convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode using LocationPath class to ensure BE can properly read the file.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)