Skip to content

branch-3.0: [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe #49645 #49750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 22, 2025
Merged

branch-3.0: [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe #49645 #49750

dataroaring merged 1 commit into from
Apr 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 2, 2025

Cherry-picked from #49645

@suxiaogang223
[fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe (#…
52a6bdd 
…49645)

### What problem does this PR solve?
Related PR: #34743 

Problem Summary:
The problem occurs because FE passes the deletion file URL with 'oss://'
prefix to BE, which cannot recognize this URL format. The solution is to
convert the 'oss://' prefix to 's3://' prefix in FE's PaimonScanNode
using LocationPath class to ensure BE can properly read the file.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 2, 2025 02:21
@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 2, 2025
@dataroaring dataroaring reopened this Apr 2, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

run buildall

dataroaring
dataroaring approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 7, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 7, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit c2976b5 into branch-3.0 Apr 22, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49645-branch-3.0 branch April 22, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @dataroaring @suxiaogang223