Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](gson) Fix GSON pretty printting setting #37211

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jul 3, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Jul 3, 2024

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39847 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 776c1dd4b0d4040722c86102ae24a3c0281f7edc, data reload: false

------ Round 1 ----------------------------------
q1	17745	4391	4268	4268
q2	2011	187	188	187
q3	11172	1262	1165	1165
q4	10725	767	876	767
q5	7832	2696	2617	2617
q6	230	143	142	142
q7	985	610	612	610
q8	9599	2092	2091	2091
q9	9006	6617	6603	6603
q10	9062	3705	3698	3698
q11	441	241	239	239
q12	441	239	228	228
q13	17785	2981	2957	2957
q14	275	223	225	223
q15	528	494	489	489
q16	532	379	379	379
q17	954	644	719	644
q18	7942	7569	7446	7446
q19	1959	1287	1235	1235
q20	658	332	328	328
q21	4876	3190	3908	3190
q22	397	351	341	341
Total cold run time: 115155 ms
Total hot run time: 39847 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4387	4261	4256	4256
q2	382	264	268	264
q3	3000	2730	2906	2730
q4	1979	1676	1718	1676
q5	5484	5427	5437	5427
q6	234	139	135	135
q7	2258	1871	1874	1871
q8	3259	3407	3409	3407
q9	8633	8704	8719	8704
q10	4061	3869	3829	3829
q11	590	504	495	495
q12	835	648	640	640
q13	16316	3170	3214	3170
q14	309	288	283	283
q15	542	486	487	486
q16	517	450	429	429
q17	1828	1548	1509	1509
q18	8113	7931	7809	7809
q19	1696	1474	1616	1474
q20	2074	1864	1814	1814
q21	10412	4914	5007	4914
q22	634	539	564	539
Total cold run time: 77543 ms
Total hot run time: 55861 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172537 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 776c1dd4b0d4040722c86102ae24a3c0281f7edc, data reload: false

query1	922	399	372	372
query2	6181	2456	2352	2352
query3	6651	202	206	202
query4	18806	17456	17147	17147
query5	3697	476	487	476
query6	288	200	164	164
query7	4590	293	292	292
query8	328	311	306	306
query9	8393	2376	2354	2354
query10	586	319	288	288
query11	10574	10133	10090	10090
query12	126	84	80	80
query13	1624	358	370	358
query14	10264	7540	6039	6039
query15	219	196	191	191
query16	7833	268	263	263
query17	1908	548	522	522
query18	1786	267	277	267
query19	187	149	149	149
query20	88	81	100	81
query21	209	134	121	121
query22	4481	4309	4196	4196
query23	33796	33694	33310	33310
query24	11746	2893	2876	2876
query25	670	396	399	396
query26	1686	150	153	150
query27	3054	324	332	324
query28	7664	2124	2112	2112
query29	1017	642	648	642
query30	258	157	156	156
query31	978	757	746	746
query32	96	55	57	55
query33	739	284	294	284
query34	1049	475	484	475
query35	747	639	609	609
query36	1145	984	970	970
query37	277	82	79	79
query38	2988	2820	2808	2808
query39	890	856	780	780
query40	252	124	121	121
query41	52	49	50	49
query42	117	96	102	96
query43	583	542	533	533
query44	1132	733	736	733
query45	193	164	160	160
query46	1086	694	740	694
query47	1878	1782	1772	1772
query48	371	299	300	299
query49	935	402	409	402
query50	773	381	380	380
query51	6829	6822	6794	6794
query52	103	91	91	91
query53	369	291	298	291
query54	864	462	443	443
query55	76	74	75	74
query56	278	263	259	259
query57	1161	1094	1032	1032
query58	239	242	244	242
query59	3337	3230	3247	3230
query60	297	284	311	284
query61	94	91	92	91
query62	594	447	429	429
query63	311	286	288	286
query64	9591	2214	1734	1734
query65	3140	3107	3075	3075
query66	1217	321	342	321
query67	15487	15032	15000	15000
query68	4553	541	539	539
query69	480	314	314	314
query70	1170	1145	1108	1108
query71	376	281	275	275
query72	6807	5308	5939	5308
query73	766	326	319	319
query74	6005	5545	5500	5500
query75	3354	2686	2725	2686
query76	2703	918	942	918
query77	492	288	299	288
query78	10373	9720	9750	9720
query79	2225	504	508	504
query80	1140	467	486	467
query81	583	223	225	223
query82	791	102	102	102
query83	236	163	168	163
query84	237	85	87	85
query85	2055	295	281	281
query86	488	337	315	315
query87	3263	3110	3033	3033
query88	3973	2418	2441	2418
query89	462	381	373	373
query90	1820	181	182	181
query91	130	101	101	101
query92	57	47	48	47
query93	2422	514	512	512
query94	1157	184	184	184
query95	407	317	322	317
query96	610	274	271	271
query97	3186	3046	2985	2985
query98	288	216	192	192
query99	1184	819	811	811
Total cold run time: 273693 ms
Total hot run time: 172537 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 776c1dd4b0d4040722c86102ae24a3c0281f7edc, data reload: false

query1	0.05	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.04	0.06
query4	1.68	0.08	0.10
query5	0.50	0.48	0.48
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.54	0.48	0.48
query10	0.53	0.55	0.54
query11	0.16	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.60	0.58
query14	0.78	0.76	0.80
query15	0.86	0.81	0.83
query16	0.36	0.37	0.37
query17	0.97	1.06	1.05
query18	0.23	0.27	0.25
query19	1.75	1.75	1.77
query20	0.01	0.01	0.01
query21	15.41	0.75	0.65
query22	3.66	8.64	1.55
query23	18.33	1.50	1.33
query24	2.15	0.23	0.22
query25	0.16	0.09	0.08
query26	0.28	0.19	0.19
query27	0.08	0.08	0.09
query28	13.23	1.02	0.99
query29	12.58	3.28	3.25
query30	0.25	0.06	0.04
query31	2.88	0.39	0.38
query32	3.28	0.48	0.47
query33	2.94	2.89	2.88
query34	17.13	4.42	4.38
query35	4.49	4.45	4.49
query36	0.64	0.47	0.48
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.19	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 108.92 s
Total hot run time: 30.28 s

@dataroaring dataroaring merged commit 156d926 into apache:master Jul 3, 2024
27 of 30 checks passed
@w41ter w41ter deleted the fix_gson_pretty_printing branch July 3, 2024 14:14
dataroaring pushed a commit to dataroaring/incubator-doris that referenced this pull request Jul 5, 2024
dataroaring pushed a commit that referenced this pull request Aug 5, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 9, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 9, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 9, 2024
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 9, 2024
w41ter added a commit that referenced this pull request Aug 9, 2024
w41ter added a commit that referenced this pull request Aug 9, 2024
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants