Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](gson) Fix gson Pretty Printing #38886

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Aug 5, 2024

This was introduced in #37211

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Aug 5, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 5, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41374 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4831217551a4bb07cfaa7e7c74431ce28343902f, data reload: false

------ Round 1 ----------------------------------
q1	17649	4068	4035	4035
q2	2020	200	208	200
q3	10450	1320	1250	1250
q4	10188	773	932	773
q5	7661	2901	2953	2901
q6	219	132	133	132
q7	1046	613	601	601
q8	9424	1901	1923	1901
q9	8411	6593	6581	6581
q10	8720	3792	3810	3792
q11	428	255	249	249
q12	409	225	227	225
q13	17763	2935	2959	2935
q14	273	243	243	243
q15	520	498	500	498
q16	531	394	385	385
q17	951	923	897	897
q18	8020	7299	7342	7299
q19	1685	1234	1214	1214
q20	573	331	323	323
q21	5375	4664	4780	4664
q22	339	276	289	276
Total cold run time: 112655 ms
Total hot run time: 41374 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4083	4045	4064	4045
q2	326	218	223	218
q3	3037	2983	3152	2983
q4	1980	1992	1977	1977
q5	5583	5576	5468	5468
q6	234	131	130	130
q7	2161	1793	1877	1793
q8	3303	3329	3344	3329
q9	8687	8907	8971	8907
q10	4119	4193	4093	4093
q11	580	492	482	482
q12	831	689	707	689
q13	16615	3141	3111	3111
q14	306	277	288	277
q15	553	530	520	520
q16	463	401	431	401
q17	1826	1766	1782	1766
q18	8183	7671	7586	7586
q19	3059	1705	1704	1704
q20	2060	1845	1874	1845
q21	5627	5440	5408	5408
q22	522	446	470	446
Total cold run time: 74138 ms
Total hot run time: 57178 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168746 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4831217551a4bb07cfaa7e7c74431ce28343902f, data reload: false

query1	912	375	359	359
query2	6458	1665	1654	1654
query3	6668	211	227	211
query4	19800	17544	17360	17360
query5	3690	511	513	511
query6	272	188	174	174
query7	4596	317	289	289
query8	252	192	197	192
query9	8524	2397	2374	2374
query10	438	281	284	281
query11	10431	10083	9904	9904
query12	127	90	96	90
query13	1629	374	375	374
query14	9307	6588	7471	6588
query15	211	161	167	161
query16	6971	480	395	395
query17	949	580	550	550
query18	1935	287	301	287
query19	196	150	149	149
query20	93	87	88	87
query21	205	112	104	104
query22	4413	3949	3918	3918
query23	33962	33548	33943	33548
query24	9521	3134	3167	3134
query25	646	410	405	405
query26	1081	154	148	148
query27	2215	287	281	281
query28	7033	2049	2024	2024
query29	996	457	431	431
query30	247	153	158	153
query31	969	765	777	765
query32	101	57	56	56
query33	726	322	333	322
query34	961	482	498	482
query35	867	765	797	765
query36	1044	892	856	856
query37	153	81	80	80
query38	2930	2764	2757	2757
query39	871	809	805	805
query40	205	111	109	109
query41	50	43	43	43
query42	123	98	101	98
query43	483	416	407	407
query44	1192	731	738	731
query45	208	176	181	176
query46	1098	803	763	763
query47	1813	1689	1700	1689
query48	364	306	303	303
query49	851	416	425	416
query50	896	432	437	432
query51	6832	6622	6625	6622
query52	101	89	88	88
query53	252	178	177	177
query54	602	457	452	452
query55	77	74	73	73
query56	273	258	254	254
query57	1123	1032	1071	1032
query58	264	267	259	259
query59	2677	2408	2359	2359
query60	298	275	265	265
query61	110	92	94	92
query62	882	658	664	658
query63	212	183	179	179
query64	4416	1881	1867	1867
query65	3156	3118	3119	3118
query66	957	337	330	330
query67	15386	14717	14674	14674
query68	4541	568	588	568
query69	688	373	293	293
query70	1076	1067	1092	1067
query71	458	279	287	279
query72	7616	2679	2479	2479
query73	831	321	377	321
query74	6000	5643	5604	5604
query75	3462	2732	2710	2710
query76	2970	1280	1274	1274
query77	692	320	324	320
query78	9387	8887	8901	8887
query79	1295	537	543	537
query80	771	502	499	499
query81	573	228	227	227
query82	275	131	131	131
query83	195	168	168	168
query84	273	77	76	76
query85	919	316	305	305
query86	388	278	306	278
query87	3273	3123	3085	3085
query88	3696	2419	2429	2419
query89	377	293	297	293
query90	1805	196	189	189
query91	122	98	167	98
query92	61	49	49	49
query93	1446	615	624	615
query94	829	293	256	256
query95	380	261	253	253
query96	604	284	284	284
query97	3214	3074	3034	3034
query98	250	201	200	200
query99	1626	1258	1314	1258
Total cold run time: 257394 ms
Total hot run time: 168746 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4831217551a4bb07cfaa7e7c74431ce28343902f, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.23	0.05	0.04
query4	1.66	0.08	0.07
query5	0.48	0.48	0.48
query6	1.15	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.57	0.56	0.56
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	0.78	0.80	0.79
query15	0.91	0.88	0.87
query16	0.37	0.36	0.35
query17	1.02	1.03	1.00
query18	0.23	0.22	0.21
query19	1.84	1.74	1.75
query20	0.01	0.01	0.02
query21	15.39	0.74	0.66
query22	4.06	6.66	1.46
query23	18.05	1.36	1.33
query24	2.26	0.22	0.21
query25	0.18	0.09	0.08
query26	0.33	0.23	0.21
query27	0.45	0.24	0.22
query28	13.16	1.01	0.98
query29	12.53	3.30	3.31
query30	0.26	0.07	0.05
query31	2.86	0.41	0.40
query32	3.23	0.48	0.48
query33	2.95	2.95	2.98
query34	15.44	4.27	4.26
query35	4.27	4.28	4.29
query36	0.68	0.47	0.49
query37	0.18	0.16	0.17
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.16	0.13	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 107.78 s
Total hot run time: 30.25 s

@dataroaring dataroaring merged commit a2775d9 into apache:master Aug 5, 2024
31 of 32 checks passed
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged doing reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants