[BUG]Fix broker read buffer size from input stream #3881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
Jun 16, 2020
| "end of file reached"); | ||
| } | ||
| return ByteBuffer.wrap(buf, 0, readLength); | ||
| logger.info("read length:" + length + ", readBufferSize:" + readBufferSize + ", return length:" + readLength); |
Contributor
There was a problem hiding this comment.
Maybe too many logs here.
morningman
reviewed
Jun 16, 2020
| "end of file reached"); | ||
| } | ||
| return ByteBuffer.wrap(buf, 0, readLength); | ||
| logger.debug("read buffer from input stream, buffer size:" + buf.capacity() + ", read length:" + readLength); |
Contributor
There was a problem hiding this comment.
if (logger.isDebugEnable()) {
logger.debug("read buffer from input stream, buffer size: {}, read length: {}", buf.capacity(), readLength);
}
morningman
added
approved
morningman
added a commit
that referenced
this pull request
Jun 20, 2020
This bug is introduced by PR #3784 In #3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead. But actually, there are some place that should use the serving catalog explicitly. Mainly changed: 1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance. 2. Fix a compile bug of broker introduced by #3881
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 22, 2020
This bug is introduced by PR apache#3784 In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead. But actually, there are some place that should use the serving catalog explicitly. Mainly changed: 1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance. 2. Fix a compile bug of broker introduced by apache#3881
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
This bug is introduced by PR apache#3784 In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead. But actually, there are some place that should use the serving catalog explicitly. Mainly changed: 1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance. 2. Fix a compile bug of broker introduced by apache#3881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3879
This commit fixs a bug that broker cannot read the full length of buffer size, when the buffer size is set larger than 128k.
This bug will cause the data size returned by pread request to be less than 128K all the time.