Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 19, 2020

This bug is introduced by PR #3784
In #3784, I remove the Catalog.getInstance(), and use Catalog.getCurrentCatalog() instead.

But actually, there are some place that should use the serving catalog explicitly.

Mainly changed:

  1. Add a new method getServingCatalog() to explicitly return the real catalog instance.
  2. Fix a compile bug of broker introduced by [BUG]Fix broker read buffer size from input stream #3881

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Jun 19, 2020
@morningman morningman self-assigned this Jun 19, 2020
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jun 19, 2020
@morningman morningman merged commit 8e89595 into apache:master Jun 20, 2020
morningman added a commit to morningman/doris that referenced this pull request Jun 22, 2020
This bug is introduced by PR apache#3784 
In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead.

But actually, there are some place that should use the serving catalog explicitly.

Mainly changed:

1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance.
2. Fix a compile bug of broker introduced by apache#3881
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
This bug is introduced by PR apache#3784
In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead.

But actually, there are some place that should use the serving catalog explicitly.

Mainly changed:

1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance.
2. Fix a compile bug of broker introduced by apache#3881
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants