Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost (#41480) #41439

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost (#41480) #41439

merged 1 commit into from
Oct 11, 2024

Conversation

zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Sep 28, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

cherry-pick #41480

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhannngchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.11% (9348/25887)
Line Coverage: 27.63% (76772/277844)
Region Coverage: 26.42% (39416/149208)
Branch Coverage: 23.20% (20058/86468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a601227b88b35f6a3477e0ffa2c9a6c0ba193efd_a601227b88b35f6a3477e0ffa2c9a6c0ba193efd/report/index.html

@zhannngchen zhannngchen changed the title [opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost [opt](merge-on-write) avoid to check delete bitmap while lookup rowkey in some situation to reduce CPU cost (#41480) Sep 29, 2024
@dataroaring dataroaring merged commit b489cdf into apache:branch-2.1 Oct 11, 2024
22 of 24 checks passed
@bobhan1 bobhan1 mentioned this pull request Oct 15, 2024
Closed
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 15, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
5545303 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 15, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
ccf869c 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 15, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
366a027 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480
@bobhan1 bobhan1 mentioned this pull request Oct 15, 2024
Merged
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 15, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
0a43bff 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 16, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
dfbc0eb 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480
bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 16, 2024
@zhannngchen @bobhan1
pick [opt](merge-on-write) avoid to check delete bitmap while lookup …
705669f 
…rowkey in some situation to reduce CPU cost (apache#41480) (apache#41439)

Issue Number: close #xxx

cherry-pick apache#41480

fix
yiguolei pushed a commit that referenced this pull request Oct 17, 2024
@bobhan1
[branch-2.1] Fix is_partial_update parameter is not set in `append_…
b821495 
…block_with_partial_content()` (#41865)

#41439 forgets to set
`is_partial_update` parameter for `Tablet::lookup_row_key()` in
`append_block_with_partial_content()`
bobhan1 added a commit to bobhan1/doris that referenced this pull request Oct 21, 2024
@bobhan1
pick fleixble partial update PRs for anta
c7c5dc8 
pick the following PRs:

other PR:
- apache#39619
- apache#40062
- apache#40272
- apache#40364
- apache#40736
- apache#41439

main PR:
- apache#39756
- apache#41950
- apache#41701
bobhan1 added a commit to bobhan1/doris that referenced this pull request Nov 12, 2024
@bobhan1
[Fix](flexible partial update) revert "[opt](merge-on-write) avoid to…
05c298b 
… check delete bitmap while lookup rowkey in some situation to reduce CPU cost (apache#41480) apache#41439" (apache#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev/2.1.7-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhannngchen @doris-robot @yiguolei @dataroaring