Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt](flexible partial update) let SegmentWriter do not support flexible partial update #41950

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[Opt](flexible partial update) let SegmentWriter do not support flexible partial update #41950

merged 2 commits into from
Oct 22, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Oct 16, 2024 •
edited
Loading

Considering that SegmentWriter will be removed in the near future, we stop to support flexible partial update on SegmentWriter to reduce maintenance costs

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Oct 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.48% (9709/25906)
Line Coverage: 28.76% (80632/280320)
Region Coverage: 28.19% (41714/147960)
Branch Coverage: 24.76% (21206/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/268087e1a281900adea2d184ef722f062c5083fb_268087e1a281900adea2d184ef722f062c5083fb/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Oct 17, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25911)
Line Coverage: 28.76% (80618/280328)
Region Coverage: 28.18% (41702/147974)
Branch Coverage: 24.76% (21207/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/01a097d96a5fed33dc03623fe9bcf45740a83ac8_01a097d96a5fed33dc03623fe9bcf45740a83ac8/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Oct 17, 2024

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Oct 17, 2024

run external

@bobhan1 bobhan1 requested a review from dataroaring October 18, 2024 10:37
zhannngchen
zhannngchen approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1 bobhan1 mentioned this pull request Oct 18, 2024
Closed
dataroaring
dataroaring approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bobhan1 added a commit to bobhan1/doris that referenced this pull request Oct 21, 2024
@bobhan1
pick fleixble partial update PRs for anta
c7c5dc8 
pick the following PRs:

other PR:
- apache#39619
- apache#40062
- apache#40272
- apache#40364
- apache#40736
- apache#41439

main PR:
- apache#39756
- apache#41950
- apache#41701
@dataroaring dataroaring merged commit 4c09663 into apache:master Oct 22, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobhan1 @doris-robot @zhannngchen @dataroaring