Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement](minor) Reduce locking scope #41844

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[Improvement](minor) Reduce locking scope #41844

merged 1 commit into from
Oct 15, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 15, 2024 •
edited
Loading

Proposed changes

pick #41845

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.03% (9342/25927)
Line Coverage: 27.61% (76741/277964)
Region Coverage: 26.42% (39433/149248)
Branch Coverage: 23.20% (20062/86456)
Coverage Report: http://coverage.selectdb-in.cc/coverage/de251b0cba0e2b4278b5dbcc2a3c71412bf533b7_de251b0cba0e2b4278b5dbcc2a3c71412bf533b7/report/index.html

@Gabriel39 Gabriel39 merged commit b91d8e2 into apache:branch-2.1 Oct 15, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabriel39 @doris-robot @yiguolei