Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement](minor) Reduce locking scope #41845

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Improvement](minor) Reduce locking scope #41845

merged 2 commits into from
Oct 15, 2024

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39 Gabriel39 mentioned this pull request Oct 15, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41522 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b0e56f8cb5e4ebc2cea0d71cf85b55d81ce99cbd, data reload: false

------ Round 1 ----------------------------------
q1	17571	7535	7493	7493
q2	2038	162	168	162
q3	10558	1144	1146	1144
q4	10232	835	790	790
q5	7727	3138	3091	3091
q6	239	162	162	162
q7	1044	645	637	637
q8	9596	1989	1996	1989
q9	7553	6428	6462	6428
q10	7155	2401	2418	2401
q11	444	253	265	253
q12	591	221	225	221
q13	17778	3021	2997	2997
q14	239	216	221	216
q15	580	529	511	511
q16	671	598	573	573
q17	999	685	513	513
q18	7418	6682	6970	6682
q19	1355	982	938	938
q20	486	195	186	186
q21	4242	3208	3134	3134
q22	1105	1033	1001	1001
Total cold run time: 109621 ms
Total hot run time: 41522 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7336	7321	7343	7321
q2	327	242	231	231
q3	2947	2775	2792	2775
q4	2032	1719	1766	1719
q5	5478	5502	5484	5484
q6	224	150	148	148
q7	2172	1716	1709	1709
q8	3273	3463	3447	3447
q9	8646	8612	8609	8609
q10	3485	3447	3440	3440
q11	580	476	478	476
q12	787	596	588	588
q13	13044	2988	2995	2988
q14	290	288	265	265
q15	579	520	514	514
q16	674	641	646	641
q17	1815	1632	1588	1588
q18	7812	7457	7508	7457
q19	1699	1510	1476	1476
q20	2062	1818	1835	1818
q21	5424	5271	5181	5181
q22	1121	1067	1018	1018
Total cold run time: 71807 ms
Total hot run time: 58893 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9708/25916)
Line Coverage: 28.74% (80613/280486)
Region Coverage: 28.19% (41704/147963)
Branch Coverage: 24.76% (21205/85632)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b0e56f8cb5e4ebc2cea0d71cf85b55d81ce99cbd_b0e56f8cb5e4ebc2cea0d71cf85b55d81ce99cbd/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191565 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b0e56f8cb5e4ebc2cea0d71cf85b55d81ce99cbd, data reload: false

query1	931	390	385	385
query2	4184	2064	2003	2003
query3	4854	209	225	209
query4	33557	23591	23647	23591
query5	3119	476	462	462
query6	221	168	161	161
query7	3923	296	287	287
query8	253	230	232	230
query9	8132	2788	2786	2786
query10	414	279	280	279
query11	17639	15361	15221	15221
query12	150	97	102	97
query13	1494	445	442	442
query14	9386	7005	7588	7005
query15	277	183	179	179
query16	7093	446	489	446
query17	1317	569	568	568
query18	1952	302	299	299
query19	308	155	151	151
query20	121	108	108	108
query21	217	103	104	103
query22	4831	4543	4446	4446
query23	35061	34103	34135	34103
query24	10678	2721	2811	2721
query25	642	402	416	402
query26	1210	158	155	155
query27	2190	281	285	281
query28	7053	2462	2426	2426
query29	818	427	421	421
query30	319	165	156	156
query31	1040	781	845	781
query32	95	56	56	56
query33	759	291	275	275
query34	921	496	525	496
query35	909	757	740	740
query36	1108	953	936	936
query37	153	90	96	90
query38	3989	3942	3931	3931
query39	1514	1429	1432	1429
query40	215	99	98	98
query41	49	45	46	45
query42	114	98	102	98
query43	533	481	465	465
query44	1282	837	811	811
query45	198	164	166	164
query46	1162	697	704	697
query47	1976	1860	1888	1860
query48	426	336	319	319
query49	1207	417	415	415
query50	836	388	398	388
query51	7197	6904	6856	6856
query52	97	90	89	89
query53	261	188	188	188
query54	1215	429	431	429
query55	82	78	76	76
query56	292	256	256	256
query57	1250	1157	1167	1157
query58	241	240	262	240
query59	3095	3070	2939	2939
query60	295	269	263	263
query61	104	101	102	101
query62	907	660	663	660
query63	221	183	183	183
query64	3744	630	606	606
query65	3302	3239	3197	3197
query66	918	312	290	290
query67	16853	16313	15729	15729
query68	3999	562	541	541
query69	473	289	281	281
query70	1136	1124	1115	1115
query71	328	263	273	263
query72	7044	3945	3909	3909
query73	783	353	366	353
query74	10036	9003	9014	9003
query75	3497	2697	2658	2658
query76	2793	809	913	809
query77	644	283	287	283
query78	10553	9679	9665	9665
query79	1726	579	612	579
query80	1117	452	433	433
query81	566	241	241	241
query82	754	134	140	134
query83	347	141	137	137
query84	276	70	68	68
query85	1066	286	290	286
query86	333	289	269	269
query87	4553	4408	4337	4337
query88	3366	2218	2182	2182
query89	403	287	300	287
query90	1824	188	190	188
query91	143	105	103	103
query92	64	46	48	46
query93	1070	546	538	538
query94	826	285	295	285
query95	326	253	240	240
query96	604	284	281	281
query97	3296	3110	3077	3077
query98	220	194	194	194
query99	1549	1307	1304	1304
Total cold run time: 286619 ms
Total hot run time: 191565 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b0e56f8cb5e4ebc2cea0d71cf85b55d81ce99cbd, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.10	0.10
query5	0.52	0.50	0.52
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.56	0.50	0.49
query10	0.54	0.55	0.54
query11	0.13	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.68	2.84	2.75
query15	0.92	0.83	0.82
query16	0.39	0.39	0.39
query17	1.07	1.02	1.04
query18	0.20	0.20	0.19
query19	1.98	1.86	1.88
query20	0.01	0.01	0.02
query21	15.36	0.58	0.58
query22	2.67	1.81	2.12
query23	16.88	1.04	0.90
query24	2.98	0.35	1.48
query25	0.18	0.17	0.06
query26	0.48	0.14	0.13
query27	0.05	0.04	0.03
query28	11.20	1.10	1.06
query29	12.56	3.22	3.20
query30	0.24	0.06	0.06
query31	2.87	0.38	0.36
query32	3.29	0.45	0.46
query33	2.99	3.02	2.97
query34	17.07	4.41	4.46
query35	4.57	4.50	4.50
query36	0.65	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.02	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.42 s
Total hot run time: 32.04 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@Gabriel39 Gabriel39 merged commit 9db2c8f into apache:master Oct 15, 2024
26 of 28 checks passed
Gabriel39 added a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[Improvement](minor) Reduce locking scope (#41845) (#41844)
b91d8e2 
pick #41845
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 17, 2024
@Gabriel39
[Improvement](minor) Reduce locking scope (apache#41845)
399afd1
@Gabriel39 Gabriel39 mentioned this pull request Oct 17, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 17, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-3.0) pick #41292 #41589 #41628 #41743 #41845 #41857 #41902
9066903 
 #41601 #41667 #41751 (#42031)

pick #41292 #41589 #41628 #41743 #41845 #41857 #41902 #41601 #41667
#41751

Co-authored-by: Pxl <pxl290@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @yiguolei @BiteTheDDDDt