-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](thirdparty) Disable BRPC 1.4 contention profiler to avoid deadlock #41891
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
|
run buildall |
TPC-H: Total hot run time: 41377 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 192189 ms
|
ClickBench: Total hot run time: 32.75 s
|
TeamCity be ut coverage result: |
…ock (apache#41891) BRPC contention profiler hooks pthread mutex, which may deadlock when used with Jemalloc. This PR remove pthread mutex hook and disable BRPC contention profiler. ![image](https://github.com/user-attachments/assets/62ccc04c-718a-43db-8354-b1bbc0565958) similar issue: apache/brpc#2726 reference fix: apache/brpc#2727
bRPC 1.4 does not contain the code of apache/brpc#2692, so there is no issue of apache/brpc#2726. The real issue should be apache/brpc#859, which has been resolved in apache/brpc#2684. In addition, bRPC 1.11 supports disabling pthread mutex hook with NO_PTHREAD_MUTEX_HOOK macro. |
Thanks for your suggestion! this PR simply disables pthread mutex hook and contention profiler. Next, I will consider pick apache/brpc#2684, or upgrading bRPC version (I tried several times, so sad) |
…ock (apache#41891) BRPC contention profiler hooks pthread mutex, which may deadlock when used with Jemalloc. This PR remove pthread mutex hook and disable BRPC contention profiler. ![image](https://github.com/user-attachments/assets/62ccc04c-718a-43db-8354-b1bbc0565958) similar issue: apache/brpc#2726 reference fix: apache/brpc#2727
BRPC contention profiler hooks pthread mutex, which may deadlock when used with Jemalloc.
This PR remove pthread mutex hook and disable BRPC contention profiler.
similar issue: apache/brpc#2726
reference fix: apache/brpc#2727