Skip to content

Commit

Permalink
[fix](thirdparty) Disable BRPC 1.4 contention profiler to avoid deadl…
Browse files Browse the repository at this point in the history
…ock (apache#41891)

BRPC contention profiler hooks pthread mutex, which may deadlock when
used with Jemalloc.
This PR remove pthread mutex hook and disable BRPC contention profiler.

![image](https://github.com/user-attachments/assets/62ccc04c-718a-43db-8354-b1bbc0565958)

similar issue: apache/brpc#2726
reference fix: apache/brpc#2727
  • Loading branch information
xinyiZzz committed Oct 16, 2024
1 parent e6545a3 commit f891f4d
Show file tree
Hide file tree
Showing 2 changed files with 421 additions and 1 deletion.
3 changes: 2 additions & 1 deletion thirdparty/download-thirdparty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@ if [[ "${BRPC_SOURCE}" == 'brpc-1.4.0' ]]; then
cd "${TP_SOURCE_DIR}/${BRPC_SOURCE}"
if [[ ! -f "${PATCHED_MARK}" ]]; then
for patch_file in "${TP_PATCH_DIR}"/brpc-*; do
patch -p1 <"${patch_file}"
echo "patch ${patch_file}"
patch -p1 --ignore-whitespace <"${patch_file}"
done
touch "${PATCHED_MARK}"
fi
Expand Down
Loading

0 comments on commit f891f4d

Please sign in to comment.