Unified the grammer style of create/drop bitmap and bloomfilter index #4247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Aug 4, 2020
| public static final ScalarType HLL = ScalarType.createHllType(); | ||
| public static final ScalarType CHAR = (ScalarType) ScalarType.createCharType(-1); | ||
| public static final ScalarType BITMAP = new ScalarType(PrimitiveType.BITMAP); | ||
| public static final ScalarType BLOOMFILTER = new ScalarType(PrimitiveType.BLOOMFILTER); |
Contributor
There was a problem hiding this comment.
No need to add a new type bloomfilter
This bitmap is Type Bitmap, not index bitmap
HangyuanLiu
requested changes
Aug 6, 2020
| processDropIndex((DropIndexClause) alterClause, olapTable, newIndexes); | ||
| DropIndexClause clause = (DropIndexClause) alterClause; | ||
| if (getIndexTypeByName(clause, olapTable) == IndexDef.IndexType.BLOOMFILTER) { | ||
| createBfJob(db.getId(), olapTable, indexSchemaMap, propertyMap, newIndexes, true); |
Contributor
Author
There was a problem hiding this comment.
createBfJob is a new Function that responsible for bloomfilter index create/drop
Contributor
There was a problem hiding this comment.
I see, but createBfJob is ambiguous
morningman
added
the
api-review
HangyuanLiu
reviewed
Aug 11, 2020
| 1. 目前只支持bitmap 索引 | ||
| 1. 目前支持bitmap,bloomfilter 索引 | ||
| 2. BITMAP 索引仅在单列上创建 | ||
| 3. BLOOMFILTER索引可以在多列上创建，当列为空时表示删除索引；属性bloom_filter_fpp表示期望误差率 |
| LOG.info("finished to create schema change job: {}", schemaChangeJob.getJobId()); | ||
| } | ||
|
|
||
| private void createBfJob(long dbId, OlapTable olapTable, Map<Long, LinkedList<Column>> indexSchemaMap, |
Contributor
There was a problem hiding this comment.
Can you reuse the old logic in createJob
| processDropIndex((DropIndexClause) alterClause, olapTable, newIndexes); | ||
| DropIndexClause clause = (DropIndexClause) alterClause; | ||
| if (getIndexTypeByName(clause, olapTable) == IndexDef.IndexType.BLOOMFILTER) { | ||
| createBfJob(db.getId(), olapTable, indexSchemaMap, propertyMap, newIndexes, true); |
Contributor
There was a problem hiding this comment.
I see, but createBfJob is ambiguous
| } | ||
| } | ||
| if (olapTable.getBfName() == indexName) { | ||
| found = new Index(); |
Contributor
There was a problem hiding this comment.
Please add a comment to explain why a new Index was created here
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Sep 1, 2025
…ailure (apache#53952) (apache#4247) 1. New tablet cloud be nullptr when get tablet action failed, take it into account. 2. Fix grammer error of the method signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is to unified the grammer style of create/drop bitmap and bloomfilter index. It supports to create bloomfilter index by using the grammar style of "create index <index_name> on <table_name> using bloomfilter comment ' ' properties ('bloom_filter_fpp'='0.04')". It is also compatible with the olde style of "alter table set ('bloom_filter_columns'='k1,k2', 'bloom_filter_fpp'='0.04')". Issue: #4193
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...