[fix](schema-change) Fix null new tablet when cleaning up sc job on failure #53952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
gavinchou
reviewed
Jul 28, 2025
| void CloudSchemaChangeJob::clean_up_on_failed() { | ||
| void CloudSchemaChangeJob::clean_up_on_failure() { | ||
| if (_new_tablet == nullptr) { | ||
| return; |
Collaborator
Author
There was a problem hiding this comment.
I think log here is pointless.
If get tablet failed, we could find details through log msg like this one:
W20250727 00:45:38.585387 5797 cloud_tablet_mgr.cpp:206] failed to tablet 1753547556254: [INVALID_ARGUMENT]failed to get tablet meta: empty instance_id
W20250727 00:45:38.599696 5797 status.h:426] meet error status: [INTERNAL_ERROR]failed to get tablet 1753547556254
0# doris::CloudTabletMgr::get_tablet(long, bool, bool, doris::SyncRowsetStats*, bool) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/common/status.h:378
1# doris::CloudSchemaChangeJob::process_alter_tablet(doris::TAlterTabletReqV2 const&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/util/expected.hpp:1986
2# doris::alter_cloud_tablet_callback(doris::CloudStorageEngine&, doris::TAgentTaskRequest const&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/common/status.h:505
3# std::_Function_handler<void (), doris::TaskWorkerPool::submit_task(doris::TAgentTaskRequest const&)::$_0::operator()<doris::TAgentTaskRequest const&>(doris::TAgentTaskRequest const&) const::{lambda()#1}>::_M_invoke(std::_Any_data const&) at /home/zcp/repo_center/doris_branch-3.0/doris/be/src/agent/task_worker_pool.cpp:546
4# doris::ThreadPool::dispatch_thread() at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1267
5# doris::Thread::supervise_thread(void*) at /var/local/ldb-toolchain/bin/../usr/include/pthread.h:563
6# ?
7# ?
Hastyshell
force-pushed
the
fix-clean-up-sc-null-tablet
branch
from
b8326b2 to
991844b
Compare
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Jul 28, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
force-pushed
the
fix-clean-up-sc-null-tablet
branch
from
991844b to
0f1aeb9
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 34123 ms |
TPC-DS: Total hot run time: 173276 ms |
ClickBench: Total hot run time: 32.79 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Jul 29, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ailure (#53952) ### What problem does this PR solve? Problem Summary: 1. New tablet cloud be nullptr when get tablet action failed, take it into account. 2. Fix grammer error of the method signature.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ailure (#53952) ### What problem does this PR solve? Problem Summary: 1. New tablet cloud be nullptr when get tablet action failed, take it into account. 2. Fix grammer error of the method signature.
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Sep 1, 2025
…ailure (apache#53952) (apache#4247) 1. New tablet cloud be nullptr when get tablet action failed, take it into account. 2. Fix grammer error of the method signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)