Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #53952

…ailure (#53952)

### What problem does this PR solve?

Problem Summary:

1. New tablet cloud be nullptr when get tablet action failed, take it
into account.
2. Fix grammer error of the method signature.
@github-actions github-actions bot requested a review from dataroaring as a code owner July 30, 2025 01:56
@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 30, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39713 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a905728a198064846d03c2481f8aee4dec85f83a, data reload: false

------ Round 1 ----------------------------------
q1	17582	6808	6613	6613
q2	2082	184	169	169
q3	10514	1109	1191	1109
q4	10221	749	708	708
q5	7732	2859	2724	2724
q6	211	129	132	129
q7	956	607	623	607
q8	9357	1943	2035	1943
q9	6739	6414	6366	6366
q10	7038	2280	2317	2280
q11	453	264	265	264
q12	433	219	222	219
q13	17807	2967	3007	2967
q14	249	206	213	206
q15	513	467	471	467
q16	504	401	373	373
q17	976	604	503	503
q18	7258	6690	6665	6665
q19	1385	1004	979	979
q20	464	199	203	199
q21	4063	3290	3218	3218
q22	1131	1005	1006	1005
Total cold run time: 107668 ms
Total hot run time: 39713 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6589	6556	6620	6556
q2	325	237	228	228
q3	2886	2895	2906	2895
q4	2033	1758	1847	1758
q5	5667	5710	5697	5697
q6	208	125	133	125
q7	2200	1822	1848	1822
q8	3370	3520	3515	3515
q9	8806	8880	8999	8880
q10	3565	3507	3532	3507
q11	598	502	489	489
q12	810	579	615	579
q13	9268	3191	3152	3152
q14	316	278	267	267
q15	501	456	470	456
q16	514	446	427	427
q17	1821	1607	1598	1598
q18	8313	7719	7860	7719
q19	1694	1582	1548	1548
q20	2015	1824	1822	1822
q21	5149	5075	4943	4943
q22	1160	1084	1032	1032
Total cold run time: 67808 ms
Total hot run time: 59015 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.90% (11136/26580)
Line Coverage 32.43% (95395/294183)
Region Coverage 31.55% (49259/156117)
Branch Coverage 27.98% (25238/90188)

@doris-robot
Copy link

TPC-DS: Total hot run time: 196629 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a905728a198064846d03c2481f8aee4dec85f83a, data reload: false

query1	1263	925	898	898
query2	6342	1884	1854	1854
query3	10927	4501	4549	4501
query4	33238	23420	23421	23420
query5	3613	460	443	443
query6	279	185	184	184
query7	3984	322	316	316
query8	286	224	222	222
query9	9443	2554	2527	2527
query10	456	269	256	256
query11	17981	15309	15199	15199
query12	159	101	103	101
query13	1544	409	421	409
query14	8569	7526	6682	6682
query15	241	183	187	183
query16	8045	527	497	497
query17	1697	603	582	582
query18	2190	316	332	316
query19	313	180	168	168
query20	138	115	113	113
query21	209	109	116	109
query22	4756	4484	4466	4466
query23	35085	34349	34376	34349
query24	11413	2851	2934	2851
query25	646	441	429	429
query26	1365	172	174	172
query27	2641	359	362	359
query28	7406	2157	2118	2118
query29	854	473	456	456
query30	278	158	165	158
query31	1062	820	875	820
query32	96	61	57	57
query33	768	314	322	314
query34	999	507	538	507
query35	883	745	727	727
query36	1110	954	964	954
query37	142	73	64	64
query38	4111	3957	4052	3957
query39	1505	1508	1462	1462
query40	202	99	102	99
query41	50	51	49	49
query42	119	104	105	104
query43	536	466	467	466
query44	1274	815	795	795
query45	185	179	164	164
query46	1147	737	732	732
query47	1973	1913	1907	1907
query48	485	410	371	371
query49	958	411	398	398
query50	829	430	443	430
query51	7394	7132	7153	7132
query52	104	94	92	92
query53	269	192	183	183
query54	1132	471	469	469
query55	83	76	77	76
query56	283	251	245	245
query57	1348	1185	1192	1185
query58	234	204	216	204
query59	3194	3030	2983	2983
query60	303	265	261	261
query61	110	105	107	105
query62	891	723	683	683
query63	229	195	199	195
query64	4473	693	656	656
query65	3334	3262	3266	3262
query66	837	308	296	296
query67	16044	15520	15753	15520
query68	4663	589	603	589
query69	462	271	258	258
query70	1187	1137	1116	1116
query71	346	260	263	260
query72	6277	4141	3957	3957
query73	756	344	348	344
query74	9583	9080	9031	9031
query75	3375	2630	2634	2630
query76	2649	1175	1074	1074
query77	401	277	274	274
query78	10454	9658	9498	9498
query79	2531	596	617	596
query80	1159	427	432	427
query81	562	213	215	213
query82	734	88	88	88
query83	232	147	140	140
query84	242	78	78	78
query85	1593	331	289	289
query86	482	284	319	284
query87	4407	4213	4221	4213
query88	4109	2369	2329	2329
query89	415	301	289	289
query90	1994	188	186	186
query91	191	145	151	145
query92	62	52	49	49
query93	2233	562	564	562
query94	796	298	297	297
query95	353	262	258	258
query96	611	282	276	276
query97	3320	3216	3130	3130
query98	217	205	198	198
query99	1525	1316	1289	1289
Total cold run time: 301978 ms
Total hot run time: 196629 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a905728a198064846d03c2481f8aee4dec85f83a, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.53	0.52	0.50
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.55	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.60	0.60
query14	0.78	0.80	0.82
query15	0.83	0.83	0.82
query16	0.40	0.38	0.38
query17	1.07	1.01	1.06
query18	0.24	0.21	0.22
query19	1.89	1.79	1.86
query20	0.02	0.01	0.01
query21	15.38	0.61	0.58
query22	2.43	2.14	1.96
query23	17.04	1.05	0.83
query24	2.92	1.21	1.15
query25	0.19	0.13	0.12
query26	0.52	0.13	0.13
query27	0.04	0.04	0.04
query28	10.12	0.52	0.46
query29	12.55	3.26	3.25
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.23	0.46	0.45
query33	2.95	3.03	3.03
query34	17.27	4.51	4.52
query35	4.54	4.56	4.57
query36	0.66	0.48	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.33 s
Total hot run time: 30.65 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 54fd374 into branch-3.0 Aug 1, 2025
23 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-53952-branch-3.0 branch August 1, 2025 08:29
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants