Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #53952

…ailure (#53952)

### What problem does this PR solve?

Problem Summary:

1. New tablet cloud be nullptr when get tablet action failed, take it
into account.
2. Fix grammer error of the method signature.
@github-actions github-actions bot requested a review from morrySnow as a code owner July 30, 2025 01:57
@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 30, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32287 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 761a3707aa21463f64888d7c517a0fdaf9d65ae8, data reload: false

------ Round 1 ----------------------------------
q1	17580	5610	5380	5380
q2	2059	290	176	176
q3	10553	1233	750	750
q4	10561	863	446	446
q5	9635	2365	2094	2094
q6	190	162	133	133
q7	923	729	613	613
q8	9333	1438	1179	1179
q9	5307	4811	4886	4811
q10	6752	2257	1809	1809
q11	474	281	261	261
q12	331	344	207	207
q13	17779	3593	3009	3009
q14	222	216	207	207
q15	525	461	477	461
q16	413	427	370	370
q17	615	860	364	364
q18	6750	6433	6342	6342
q19	1214	961	550	550
q20	320	348	203	203
q21	2943	2128	1963	1963
q22	1022	1018	959	959
Total cold run time: 105501 ms
Total hot run time: 32287 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5571	5479	5513	5479
q2	235	330	227	227
q3	2279	2608	2351	2351
q4	1331	1823	1373	1373
q5	4413	4852	4984	4852
q6	170	162	129	129
q7	2098	2016	1834	1834
q8	2627	2840	2697	2697
q9	7255	7175	7158	7158
q10	2994	3364	2762	2762
q11	563	499	493	493
q12	695	824	642	642
q13	3379	3726	3168	3168
q14	289	295	266	266
q15	512	474	493	474
q16	442	488	435	435
q17	1213	1726	1232	1232
q18	7435	7341	7444	7341
q19	782	959	1147	959
q20	2022	2019	1904	1904
q21	5375	4916	4772	4772
q22	1087	1042	1021	1021
Total cold run time: 52767 ms
Total hot run time: 51569 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197387 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 761a3707aa21463f64888d7c517a0fdaf9d65ae8, data reload: false

query1	1279	960	917	917
query2	6237	1987	1996	1987
query3	11044	4508	4499	4499
query4	32977	23730	23395	23395
query5	3677	611	470	470
query6	283	190	189	189
query7	4010	493	319	319
query8	298	258	238	238
query9	9311	2629	2606	2606
query10	465	327	253	253
query11	18204	15253	14953	14953
query12	160	107	104	104
query13	1553	550	410	410
query14	8866	7176	6979	6979
query15	213	199	188	188
query16	7947	678	492	492
query17	1539	798	606	606
query18	2054	409	319	319
query19	201	191	182	182
query20	123	118	116	116
query21	207	133	113	113
query22	4702	4592	4405	4405
query23	34740	34685	33802	33802
query24	7314	2699	2747	2699
query25	550	505	435	435
query26	1163	289	178	178
query27	2302	485	359	359
query28	5486	2258	2195	2195
query29	766	595	470	470
query30	245	198	168	168
query31	976	912	841	841
query32	80	61	62	61
query33	511	389	314	314
query34	761	856	531	531
query35	783	810	755	755
query36	1018	1087	989	989
query37	113	93	72	72
query38	4020	4040	4019	4019
query39	1601	1469	1455	1455
query40	207	119	114	114
query41	53	50	48	48
query42	119	107	104	104
query43	540	517	503	503
query44	1322	817	824	817
query45	192	175	173	173
query46	885	1052	670	670
query47	1959	1960	1938	1938
query48	417	431	343	343
query49	798	502	411	411
query50	694	693	450	450
query51	7442	7384	7363	7363
query52	108	104	95	95
query53	233	265	190	190
query54	551	545	487	487
query55	91	82	86	82
query56	286	286	263	263
query57	1269	1235	1224	1224
query58	234	213	226	213
query59	3237	3281	3122	3122
query60	300	291	269	269
query61	114	125	117	117
query62	811	765	690	690
query63	232	201	194	194
query64	4347	996	648	648
query65	3372	3290	3317	3290
query66	1018	411	318	318
query67	16370	15806	15625	15625
query68	6657	829	538	538
query69	498	304	280	280
query70	1171	1176	1156	1156
query71	392	302	261	261
query72	5967	3780	3897	3780
query73	640	749	359	359
query74	10262	9330	9180	9180
query75	3171	3153	2654	2654
query76	3204	1169	784	784
query77	465	370	277	277
query78	10456	10400	9792	9792
query79	3484	918	583	583
query80	595	523	429	429
query81	505	259	219	219
query82	613	118	88	88
query83	160	164	145	145
query84	261	103	76	76
query85	786	355	301	301
query86	406	305	299	299
query87	4258	4321	4221	4221
query88	5270	2439	2418	2418
query89	415	339	293	293
query90	1791	190	186	186
query91	135	137	108	108
query92	72	62	51	51
query93	2034	911	528	528
query94	677	393	304	304
query95	340	274	262	262
query96	503	604	285	285
query97	3205	3260	3180	3180
query98	247	205	201	201
query99	1354	1430	1305	1305
Total cold run time: 294974 ms
Total hot run time: 197387 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 761a3707aa21463f64888d7c517a0fdaf9d65ae8, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.10
query5	0.51	0.50	0.51
query6	1.12	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.51
query10	0.54	0.56	0.55
query11	0.15	0.13	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.77	0.78	0.80
query15	0.85	0.83	0.82
query16	0.37	0.39	0.38
query17	1.06	1.04	1.04
query18	0.23	0.22	0.22
query19	1.86	1.81	1.78
query20	0.01	0.00	0.01
query21	15.40	0.94	0.59
query22	0.73	0.77	0.66
query23	15.11	1.46	0.60
query24	3.26	0.51	1.21
query25	0.20	0.18	0.06
query26	0.27	0.16	0.14
query27	0.05	0.04	0.04
query28	12.78	1.06	0.43
query29	12.62	3.95	3.26
query30	0.26	0.10	0.07
query31	2.81	0.61	0.38
query32	3.23	0.54	0.46
query33	2.98	3.01	3.06
query34	16.75	5.25	4.55
query35	4.59	4.57	4.60
query36	0.63	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.02	0.03
Total cold run time: 102.95 s
Total hot run time: 28.49 s

@morrySnow morrySnow merged commit d5d96da into branch-3.1 Jul 30, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-53952-branch-3.1 branch July 30, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants