Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](array) fix add_array_null_value for inverted index_builder #42638

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[fix](array) fix add_array_null_value for inverted index_builder #42638

merged 2 commits into from
Oct 30, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

in index_builder.cpp we should also handle function add_array_null which happend in alter statement
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9718/25936)
Line Coverage: 28.75% (80640/280503)
Region Coverage: 28.17% (41691/148008)
Branch Coverage: 24.72% (21178/85668)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5969205f7506962adcc34b752bba9ff9c6fab4e7_5969205f7506962adcc34b752bba9ff9c6fab4e7/report/index.html

airborne12
airborne12 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run p0

@amorynan
Copy link
Contributor Author

run cloud_p0

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 28, 2024
@amorynan
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9718/25937)
Line Coverage: 28.73% (80608/280545)
Region Coverage: 28.15% (41681/148053)
Branch Coverage: 24.72% (21179/85686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f8afb01596934096686c4c1d079b7ab22f6b82b8_f8afb01596934096686c4c1d079b7ab22f6b82b8/report/index.html

@amorynan
Copy link
Contributor Author

run p0

airborne12
airborne12 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

eldenmoon
eldenmoon approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amorynan
Copy link
Contributor Author

run p0

@amorynan
Copy link
Contributor Author

run p0

@xiaokang xiaokang merged commit edfa1b4 into apache:master Oct 30, 2024
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
@amorynan
[fix](array) fix add_array_null_value for inverted index_builder (#42638
94eca6a 
)

in index_builder.cpp we should also handle function add_array_null which
happend in alter statement
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
@yiguolei yiguolei mentioned this pull request Oct 30, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 30, 2024
@amorynan
[fix](array) fix add_array_null_value for inverted index_builder (#42899
e43d255 
)

## Proposed changes
Pick #42638 to doris branch 2.1
Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Nov 7, 2024
@github-actions @amorynan
branch-3.0: [fix](array) fix add_array_null_value for inverted index_…
f7494dd 
…builder (#42883)

PR Body: ## Proposed changes
in index_builder.cpp we should also handle function add_array_null which
happend in alter statement
Issue Number: close #xxx

<!--Describe your changes.-->

 
 Cherry-picked from #42638

Co-authored-by: amory <wangqiannan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amorynan @doris-robot @airborne12 @eldenmoon @xiaokang @yiguolei @dataroaring