[fix](index compaction)Skip writing terms with a doc frequency of 0(#43113) #43115
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/test/olap/rowset/segment_v2/inverted_index/index_compaction_with_deleted_term.cpp
Show resolved
Hide resolved
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
| if (false) { | ||
| TermDocs* td = r->termDocs(te->term()); | ||
| while (td->next()) { | ||
| printf("DocID: %d ", td->doc()); | ||
| printf("TermFreq: %d\n", td->freq()); | ||
| } | ||
| _CLLDELETE(td); | ||
| } |
There was a problem hiding this comment.
warning: redundant boolean literal in if statement condition [readability-simplify-boolean-expr]
| if (false) { | |
| TermDocs* td = r->termDocs(te->term()); | |
| while (td->next()) { | |
| printf("DocID: %d ", td->doc()); | |
| printf("TermFreq: %d\n", td->freq()); | |
| } | |
| _CLLDELETE(td); | |
| } | |
| r->close(); | ||
| _CLLDELETE(r); | ||
| } | ||
| static Status check_idx_file_correctness(lucene::store::Directory* index_reader, |
There was a problem hiding this comment.
warning: function 'check_idx_file_correctness' exceeds recommended size/complexity thresholds [readability-function-size]
static Status check_idx_file_correctness(lucene::store::Directory* index_reader,
^Additional context
be/test/olap/rowset/segment_v2/inverted_index/index_compaction_with_deleted_term.cpp:117: 97 lines including whitespace and comments (threshold 80)
static Status check_idx_file_correctness(lucene::store::Directory* index_reader,
^| return Status::OK(); | ||
| } | ||
|
|
||
| static RowsetSharedPtr do_compaction(std::vector<RowsetSharedPtr> rowsets, |
There was a problem hiding this comment.
warning: function 'do_compaction' exceeds recommended size/complexity thresholds [readability-function-size]
static RowsetSharedPtr do_compaction(std::vector<RowsetSharedPtr> rowsets,
^Additional context
be/test/olap/rowset/segment_v2/inverted_index/index_compaction_with_deleted_term.cpp:217: 245 lines including whitespace and comments (threshold 80)
static RowsetSharedPtr do_compaction(std::vector<RowsetSharedPtr> rowsets,
^
|
run buildall |
|
TeamCity be ut coverage result: |
4 participants
bp #43113