[fix](cloud-mow) Should clear GetDeleteBitmapResponse when geting delete bitmap fail and retry #43261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ete bitmap fail and retry
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ete bitmap fail and retry (#43261) When geting delete bitmap fail, it will retry, howerve the GetDeleteBitmapResponse doesn't clear now, which will lead to the delete bitmap data of last request residual in GetDeleteBitmapResponse and return to be, it a wrong delete bitmap data and may cause be core.
16 tasks
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Dec 5, 2024
…` when geting delete bitmap update lock fail and retry (#44975) Similar to #43261, `GetDeleteBitmapUpdateLockResponse` should be cleared after `get_delete_bitmap_update_lock` fails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets before `update_delete_bitmap()` thus causing duplicate keys problem.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…` when geting delete bitmap update lock fail and retry (#44975) Similar to #43261, `GetDeleteBitmapUpdateLockResponse` should be cleared after `get_delete_bitmap_update_lock` fails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets before `update_delete_bitmap()` thus causing duplicate keys problem.
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
…n geting delete bitmap fail and retry (apache#43297) Cherry-picked from apache#43261 Co-authored-by: huanghaibin <284824253@qq.com>
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
…g delete bitmap fail and retry (apache#43358) Problem Summary: pr apache#43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix this problem
hubgeter
pushed a commit
to hubgeter/doris
that referenced
this pull request
Mar 12, 2025
…` when geting delete bitmap update lock fail and retry (apache#44975) Similar to apache#43261, `GetDeleteBitmapUpdateLockResponse` should be cleared after `get_delete_bitmap_update_lock` fails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets before `update_delete_bitmap()` thus causing duplicate keys problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geting delete bitmap fail, it will retry, howerve the GetDeleteBitmapResponse doesn't clear now, which will lead to the delete bitmap data of last request residual in GetDeleteBitmapResponse and return to be, it a wrong delete bitmap data and may cause be core.