[Fix](merge-on-write) Should clear GetDeleteBitmapUpdateLockResponse when geting delete bitmap update lock fail and retry
#44975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
reviewed
Dec 4, 2024
| << " tablet=" << res->tablet_id() | ||
| << " delete_bitmap_count=" << res->segment_delete_bitmaps_size(); | ||
| } else if constexpr (std::is_same_v<Response, GetDeleteBitmapUpdateLockResponse>) { | ||
| if (res->status().code() != MetaServiceCode::OK) { |
Contributor
There was a problem hiding this comment.
better not process rpc content here
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zhannngchen
approved these changes
Dec 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…` when geting delete bitmap update lock fail and retry (#44975) Similar to #43261, `GetDeleteBitmapUpdateLockResponse` should be cleared after `get_delete_bitmap_update_lock` fails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets before `update_delete_bitmap()` thus causing duplicate keys problem.
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
…` when geting delete bitmap update lock fail and retry (apache#44975) Similar to apache#43261, `GetDeleteBitmapUpdateLockResponse` should be cleared after `get_delete_bitmap_update_lock` fails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets before `update_delete_bitmap()` thus causing duplicate keys problem.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Similar to #43261,
GetDeleteBitmapUpdateLockResponseshould be cleared afterget_delete_bitmap_update_lockfails on MS. Otherwise BE may get staled compaction cnts and wrongly skip to sync rowsets beforeupdate_delete_bitmap()thus causing duplicate keys problem.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)