Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] replace table options to keep original dropped table in recycle bin #43538

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[Enhancement] replace table options to keep original dropped table in recycle bin #43538

merged 1 commit into from
Nov 11, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Nov 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43537

Related PR: #xxx

Problem Summary:

Release note

Replace table options to keep original dropped table in recycle bin

Check List (For Author)

  • Test

    • [ *] Regression test //added
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.
      Yes. older version will directly drop the original table when swap=false. After this PR, it will be kept in recycle bin.
      user can use Force option in replace table to directly drop table without keeping in recycle bin.

  • Does this need documentation?

    • No.
    • Yes. //updated

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 9, 2024

run buildall

@Vallishp Vallishp force-pushed the replace_table_recycle_bin branch from 99e901b to f7389c5 Compare November 9, 2024 09:25
@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 9, 2024

run buildall

@dataroaring
Copy link
Contributor

Please add document in doris-website.

@Vallishp Vallishp mentioned this pull request Nov 10, 2024
Merged
6 tasks
dataroaring
dataroaring approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yujun777
yujun777 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 37f489a into apache:master Nov 11, 2024
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
@Vallishp
[Enhancement] replace table options to keep original dropped table in…
4cabf34 
… recycle bin (#43538)


Replace table options to keep original dropped table in recycle bin

Yes. older version will directly drop the original table when
swap=false. After this PR, it will be kept in recycle bin.
user can use Force option in replace table to directly drop table
without keeping in recycle bin.
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Open
KassieZ pushed a commit to apache/doris-website that referenced this pull request Nov 27, 2024
@Vallishp
[Enhancement] replace table options to keep original dropped table in…
5623288 
… recycle bin (#1323)

[#43537](apache/doris#43537)
apache/doris#43538

# Versions 

- [ ] dev // dev version
- [ ] 3.0
- [ ] 2.1
- [ ] 2.0

# Languages

- [ ] Chinese // need update
- [ ] English // updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@yujun777 yujun777 yujun777 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] replace table options to keep original dropped table in recycle bin
4 participants
@Vallishp @doris-robot @dataroaring @yujun777