Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Enhancement] replace table options to keep original dropped table in recycle bin #43585

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #43538

… recycle bin (#43538)


Replace table options to keep original dropped table in recycle bin

Yes. older version will directly drop the original table when
swap=false. After this PR, it will be kept in recycle bin.
user can use Force option in replace table to directly drop table
without keeping in recycle bin.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42351 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4cabf34849dcda20786cd90b81f95427520efb55, data reload: false

------ Round 1 ----------------------------------
q1	11487	7425	7625	7425
q2	1657	1403	1308	1308
q3	5581	1593	1224	1224
q4	1031	766	717	717
q5	2837	2846	2847	2846
q6	241	155	153	153
q7	981	636	611	611
q8	2017	2029	2034	2029
q9	6516	6546	6424	6424
q10	2566	2323	2348	2323
q11	379	271	277	271
q12	431	222	224	222
q13	17522	2994	2995	2994
q14	251	215	231	215
q15	571	522	518	518
q16	653	603	603	603
q17	994	666	524	524
q18	7348	6624	6655	6624
q19	1188	1184	992	992
q20	393	201	202	201
q21	3982	3148	3400	3148
q22	1102	1024	979	979
Total cold run time: 69728 ms
Total hot run time: 42351 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7353	7344	7302	7302
q2	418	307	303	303
q3	2927	2772	2731	2731
q4	1939	1655	1712	1655
q5	5404	5470	5482	5470
q6	220	143	144	143
q7	2086	1634	1687	1634
q8	3354	3624	3550	3550
q9	8999	8986	9046	8986
q10	3605	3557	3504	3504
q11	593	503	498	498
q12	817	612	627	612
q13	8784	3194	3193	3193
q14	321	274	269	269
q15	605	545	554	545
q16	693	667	678	667
q17	1879	1651	1615	1615
q18	8117	7867	7743	7743
q19	1728	1679	1566	1566
q20	2084	1927	1876	1876
q21	5455	5275	5439	5275
q22	1123	1047	1010	1010
Total cold run time: 68504 ms
Total hot run time: 60147 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191920 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4cabf34849dcda20786cd90b81f95427520efb55, data reload: false

query1	2422	2219	2220	2219
query2	6379	2081	2071	2071
query3	14325	9936	236	236
query4	33178	23442	23650	23442
query5	3763	460	434	434
query6	263	175	182	175
query7	3977	313	320	313
query8	294	228	233	228
query9	9535	2700	2688	2688
query10	469	265	257	257
query11	17983	15103	15163	15103
query12	138	100	99	99
query13	1539	441	403	403
query14	9598	6413	6642	6413
query15	232	187	172	172
query16	7744	530	453	453
query17	1342	600	622	600
query18	2300	623	636	623
query19	254	193	203	193
query20	134	119	116	116
query21	209	107	105	105
query22	4623	4387	4373	4373
query23	35031	34369	34079	34079
query24	7981	3439	3435	3435
query25	585	392	390	390
query26	737	179	182	179
query27	1847	294	295	294
query28	4067	2509	2482	2482
query29	790	429	422	422
query30	397	303	309	303
query31	996	803	811	803
query32	89	54	53	53
query33	467	265	279	265
query34	893	511	509	509
query35	843	717	738	717
query36	1067	921	924	921
query37	112	67	71	67
query38	4140	3858	3888	3858
query39	1482	1441	1482	1441
query40	194	96	96	96
query41	50	47	48	47
query42	111	94	100	94
query43	532	463	505	463
query44	1183	791	781	781
query45	190	161	167	161
query46	1118	753	753	753
query47	1874	1819	1777	1777
query48	470	368	362	362
query49	840	374	374	374
query50	832	409	411	409
query51	7224	6978	7267	6978
query52	97	91	88	88
query53	261	187	181	181
query54	566	460	446	446
query55	80	75	74	74
query56	242	232	232	232
query57	1200	1106	1089	1089
query58	207	202	202	202
query59	3060	2865	2865	2865
query60	277	254	259	254
query61	110	107	106	106
query62	807	656	655	655
query63	214	202	191	191
query64	3303	644	615	615
query65	3301	3198	3185	3185
query66	784	337	301	301
query67	16028	15459	15408	15408
query68	4442	572	566	566
query69	417	260	257	257
query70	1135	1116	1036	1036
query71	343	271	267	267
query72	6318	4023	2479	2479
query73	766	345	343	343
query74	10197	8906	8881	8881
query75	3340	2652	2602	2602
query76	2311	1022	938	938
query77	417	277	269	269
query78	10513	9795	9902	9795
query79	3784	596	595	595
query80	2394	420	417	417
query81	585	242	240	240
query82	901	116	120	116
query83	276	165	161	161
query84	289	90	85	85
query85	1774	294	290	290
query86	507	297	265	265
query87	4412	4231	4224	4224
query88	4662	2360	2410	2360
query89	551	297	293	293
query90	2037	190	181	181
query91	180	144	157	144
query92	70	48	46	46
query93	6485	524	531	524
query94	850	295	277	277
query95	349	254	255	254
query96	633	287	285	285
query97	3340	3104	3208	3104
query98	226	210	198	198
query99	1742	1434	1307	1307
Total cold run time: 303626 ms
Total hot run time: 191920 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants