[License] Organize and modify the license of the code #4371
Conversation
morningman
added
kind/community
docs/en/README.md
Outdated
| actionText: Quick Start → | ||
| actionLink: /en/installing/compilation | ||
| --- | ||
|
|
There was a problem hiding this comment.
Do we need to add the License header on the markdown file?
There was a problem hiding this comment.
We have added a license header to all markdown files.
But this file is special and needs to be rendered as the homepage of the Doris website through Vuepress.
We have tried to add the license, but that will cause the rendering to fail.
Does this need to be specifically stated in the LICENSE file?
There was a problem hiding this comment.
Oh, I can put the license in the frontmatter section. I will add it
| exit 1 | ||
| fi | ||
|
|
||
| if [[ -z ${WITH_MYSQL} ]]; then |
There was a problem hiding this comment.
Just a quick question how can we enable the build with MYSQL?
There was a problem hiding this comment.
Like this:
WITH_MYSQL=ON WIHT_LZO=ON sh build.sh
I had put it in the document of compilation.md
docs/zh-CN/installing/compilation.md
Outdated
| 自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。 | ||
| 依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。 |
There was a problem hiding this comment.
建议前面依赖库前面 加一个 “移除”。
还有就是依赖库[1] 应该是MySQL client吧！
There was a problem hiding this comment.
建议前面依赖库前面 加一个 “移除”。
好的
还有就是依赖库[1] 应该是MySQL client吧！
事实上，我们在第三方库中下载了完整的 MySQL 源码，其中包括 server 和 client 部分，但是我们只使用了其中的 client 部分。注释 [1] 中标注的mysql-5.7.18，是在thirdparty/var.sh中写明的依赖名称，感觉两边一致的话，更便于用户查找。
docs/zh-CN/installing/compilation.md
Outdated
| 自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。 | ||
| 依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。 |
1. Disable the MySQL client and LZO library by default when building the Doris.
MySQL client library is used for MySQL external table feature.
This feature will be replaced by the new ODBC external table soon.
LZO library is used to compress/decompress data of some old data format of Doris,
which is no longer used anymore.
2. Add missing license to some files.
3. For all non-Apache-License code, all are explained in NOTICE file and the corresponding license is declared.
4 participants
Proposed changes
Disable the MySQL client and LZO library by default when building the Doris.
MySQL client library is used for MySQL external table feature.
This feature will be replaced by the new ODBC external table soon.
LZO library is used to compress/decompress data of some old data format of Doris,
which is no longer used anymore.
Add missing license to some files.
For all non-Apache-License code, all are explained in NOTICE file and the corresponding license is declared.
Remove the js source code from webroot, it will be downloaded as thirdparty
Types of changes
Checklist