[Bug] Fix bug of load error hub and schema change #4486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When WITH_MYSQL is off, load error hub does not suport MySQL load error hub, we should check its return value. 2. misjudge the return value of `change_row_block` in schema_change.cpp
yangzhg
reviewed
Aug 31, 2020
ZhangYu0123
pushed a commit
to ZhangYu0123/incubator-doris
that referenced
this pull request
Sep 1, 2020
1. When WITH_MYSQL is off, load error hub does not suport MySQL load error hub, we should check its return value. 2. misjudge the return value of `change_row_block` in schema_change.cpp
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When WITH_MYSQL is off, load error hub does not suport MySQL load error hub,
we should check its return value. (introduced by [License] Organize and modify the license of the code #4371 )
misjudge the return value of
change_row_blockin schema_change.cpp (Introduced by Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure #4388 )Types of changes